8000 DOC Ensures that SimpleImputer passes numpydoc validation by jmloyola · Pull Request #21077 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Ensures that SimpleImputer passes numpydoc validation #21077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2021
Merged

DOC Ensures that SimpleImputer passes numpydoc validation #21077

merged 3 commits into from
Sep 18, 2021

Conversation

jmloyola
Copy link
Member

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures SimpleImputer is compatible with numpydoc:

  • Remove SimpleImputer from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.

glemaitre
glemaitre reviewed Sep 18, 2021
View reviewed changes
@glemaitre glemaitre merged commit 07a9dc9 into scikit-learn:main Sep 18, 2021
@glemaitre
Copy link
Member

Thanks @jmloyola Looks good and thanks for changing the little for consistency.

@jmloyola jmloyola deleted the fix_numpydoc_simpleimputer branch September 18, 2021 20:50
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
@jmloyola @glemaitre @adrinjalali
DOC Ensures that SimpleImputer passes numpydoc validation (scikit-lea…
49899b2 
…rn#21077)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
adrinjalali pushed a commit that referenced this pull request Sep 23, 2021
@jmloyola @glemaitre @adrinjalali
DOC Ensures that SimpleImputer passes numpydoc validation (#21077)
635fb04 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@jmloyola @glemaitre @samronsin
DOC Ensures that SimpleImputer passes numpydoc validation (scikit-lea…
097b2ca 
…rn#21077)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

Assignees
No one assigned
Labels
Documentation module:impute
Projects
449C
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmloyola @glemaitre
0