DOC - Ensure HuberRegressor passes numpydoc validation #21062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Sep 16, 2021
| See Also | ||
| -------- | ||
| RANSACRegressor : RANSAC (RANdom SAmple Consensus) algorithm. | ||
| TheilSenRegressor : Theil-Sen Estimator robust multivariate regression model. |
There was a problem hiding this comment.
Could you add the SGDRegressor as well. This estimator can get several loss functions as the Huber loss as well.
There was a problem hiding this comment.
This comment has not been addressed yet.
There was a problem hiding this comment.
It should be added now
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Added suggestions
Added period
glemaitre
reviewed
Sep 17, 2021
|
Thanks @EricEllwanger |
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Sep 20, 2021
adrinjalali
pushed a commit
that referenced
this pull request
Sep 23, 2021
Co-authored-by: frellwan <frellwan@hotmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #20308
What does this implement/fix? Explain your changes.
Changes to file sklearn/linear_model/_huber.py:
Change the ordering of sections in HuberRegressor
Added 'See Also' Section to HuberRegressor
Added description to 'Returns' section
Removed HuberRegressor from maint_tools/test_docstrings.py DOC_IGNORE_LIST
Any other comments?