8000 DOC more whats new 1.0 fixes by adrinjalali · Pull Request #21036 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC more whats new 1.0 fixes #21036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

adrinjalali
Copy link
Member

tagging #20965

@thomasjpfan @glemaitre maybe?

@adrinjalali adrinjalali added this to the 1.0 milestone Sep 14, 2021
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question otherwise LGTM

@@ -473,11 +473,6 @@ Changelog
:func:`inspection.permutation_importance`. :pr:`19411` by :user:`Simona
Maggio <simonamaggio>`.

- |API| :class:`inspection.PartialDependenceDisplay` exposes a class method:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably miss something but why did you remove this entry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was a merge conflict issue, mistakenly removed. Put it back, thanks for noticing.

@glemaitre glemaitre merged commit 3271f76 into scikit-learn:main Sep 14, 2021
@glemaitre
Copy link
Member

Thanks @adrinjalali

@adrinjalali adrinjalali deleted the 1.0-whatsnew branch September 14, 2021 11:38
adrinjalali added a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
adrinjalali added a commit that referenced this pull request Sep 23, 2021
samronsin pushed a commit 76E4 to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0