-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC more whats new 1.0 fixes #21036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC more whats new 1.0 fixes #21036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one question otherwise LGTM
doc/whats_new/v1.0.rst
Outdated
@@ -473,11 +473,6 @@ Changelog | |||
:func:`inspection.permutation_importance`. :pr:`19411` by :user:`Simona | |||
Maggio <simonamaggio>`. | |||
|
|||
- |API| :class:`inspection.PartialDependenceDisplay` exposes a class method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably miss something but why did you remove this entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was a merge conflict issue, mistakenly removed. Put it back, thanks for noticing.
Thanks @adrinjalali |
tagging #20965
@thomasjpfan @glemaitre maybe?