8000 Version 1.0 release · Issue #20965 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Version 1.0 release #20965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
12 tasks done
adrinjalali opened this issue Sep 7, 2021 · 28 comments
Closed
12 tasks done

Version 1.0 release #20965

adrinjalali opened this issue Sep 7, 2021 · 28 comments
Milestone
1.0

Comments

@adrinjalali
Copy link
Member
adrinjalali commented Sep 7, 2021 •
edited by ogrisel
Loading

This is the issue to cover things we need to do to finish the release.

@scikit-learn/core-devs please tag this issue when you want a PR to be backported to 1.0 from now :)

Question: the travis job triggered by [cd build] succeeded, but we don't have any ARM wheels on the anaconda repo, I'm puzzled.
@adrinjalali adrinjalali added this to the 1.0 milestone Sep 7, 2021
@adrinjalali adrinjalali mentioned this issue Sep 7, 2021
Merged
@glemaitre
Copy link
Member

The ARM are located there: https://pypi.anaconda.org/scikit-learn-wheels-staging/simple/scikit-learn/

scikit_learn-1.0rc1-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
scikit_learn-1.0rc1-cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
scikit_learn-1.0rc1-cp37-cp37m-manylinux_2_17_aarch64.manylinux2014_aarch64.whl

@glemaitre
Copy link
Member

However, something is weird with the naming (basically for all manylinux that has 2 dots). I don't know if this would be an issue when installing.

@adrinjalali
Copy link
Member Author

what about the M1 chip wheels? are we doing them?

@glemaitre
Copy link
Member

Not yet. We are awaiting for SciPy to provide a wheel. It is almost there but @ogrisel just discovered the following bug a couple of days ago: scipy/scipy#14688

@adrinjalali
Copy link
Member Author

The release candidate is uploaded, and the tag is created on the release branch: https://pypi.org/project/scikit-learn/1.0rc1/

@adrinjalali adrinjalali mentioned this issue Sep 7, 2021
Merged
@adrinjalali
Copy link
Member Author

Documentation: https://scikit-learn.org/1.0/

@tupui
Copy link
tupui commented Sep 7, 2021

I see you dropped Python 3.6 for this release. Why not dropping Python 3.7? Both NumPy and SciPy dropped it on master (https://scipy.github.io/devdocs/dev/toolchain.html and xref scipy/scipy#14655 ). And it would be closer to NEP29.

@adrinjalali
Copy link
Member Author

We probably would for next release. But I'm happy to have 3 python release support for our release.

@adrinjalali adrinjalali mentioned this issue Sep 7, 2021
Merged
@thomasjpfan thomasjpfan mentioned this issue Sep 7, 2021
Merged
@glemaitre glemaitre mentioned this issue Sep 8, 2021
Merged
@adrinjalali adrinjalali mentioned this issue Sep 8, 2021
Merged
@glemaitre glemaitre mentioned this issue Sep 8, 2021
Merged
This was referenced Sep 8, 2021
Merged
Merged
Merged
Merged
@reshamas
Copy link
Member

@adrinjalali
Can we update top note to include: share on LinkedIn page:
https://www.linkedin.com/company/scikit-learn/

@adrinjalali
Copy link
Member Author

@reshamas which note do you mean?

@reshamas
Copy link
Member

@adrinjalali

@reshamas which note do you mean?

The checklist at very top of this page has an item for "announce on mailing list and on twitter".
Can we add an item for: "share on scikit-learn LinkedIn page"?

@ogrisel
Copy link
Member
ogrisel commented Sep 24, 2021

I see you dropped Python 3.6 for this release. Why not dropping Python 3.7? Both NumPy and SciPy dropped it on master (https://scipy.github.io/devdocs/dev/toolchain.html and xref scipy/scipy#14655 ). And it would be closer to NEP29.

I would take NEP29 as a minimal requirement for scikit-learn. If it's easy for us to support a little more, then let's do it. I like the last 3 Python versions rule of thumb. It's still manageable from a CI maintenance point of view.

@tupui
Copy link
tupui commented Sep 24, 2021

I see you dropped Python 3.6 for this release. Why not dropping Python 3.7? Both NumPy and SciPy dropped it on master (https://scipy.github.io/devdocs/dev/toolchain.html and xref scipy/scipy#14655 ). And it would be closer to NEP29.

I would take NEP29 as a minimal requirement for scikit-learn. If it's easy for us to support a little more, then let's do it. I like the last 3 Python versions rule of thumb. It's still manageable from a CI maintenance point of view.

Python 3.10 being out next month basically, I would read this as: let's drop Python 3.7 to support 3.8, 3.9 and 3.10.

@ogrisel
Copy link
Member
ogrisel commented Sep 24, 2021

We are about to release 1.0.0 today hopefully, so let's keep 3.7 for this one :)

@tupui
Copy link
tupui commented Sep 24, 2021

Oh great! 😃 Sure then.

@adrinjalali
Copy link
Member Author

@tupui does conda-forge hope for libraries to drop 3.7 for CPU cycles or maintainance?

Also, dropping 3.7 means probably using 3.8 syntax, which means no pypy support. I'm not sure what we think about that.

pinging @rth on this

@ogrisel
Copy link
Member
ogrisel commented Sep 24, 2021

@tupui does conda-forge hope for libraries to drop 3.7 for CPU cycles or maintainance?

Even if that's the case, it's would still be ok to support 3.7 for sdist and wheels on pypi.org.

@ogrisel
Copy link
Member
ogrisel commented Sep 24, 2021

For information, the conda-forge packages are being prepared here: conda-forge/scikit-learn-feedstock#166

@tupui
Copy link
tupui commented Sep 24, 2021

@ogrisel I would be happy to try a PR to remove 3.7 once v1 is out. Let me know if this is wanted, trying to get on board in some ways 😅

@adrinjalali
Copy link
Member Author

we probably would keep 3.7 on main for at least the first two minor releases maybe. But once it's time to do so, then you're more than welcome to remove all the 3.7 stuff 😄

@ogrisel
Copy link
Member
ogrisel commented Sep 24, 2021 •
edited
Loading

@adrinjalali can you please update the todo list of this issue? It seems that most of it is done and I am not sure what is left to do besides general announcements and updating the scikit-learn.org/stable synlink.

As @thomasjpfan said on gitter.im, we still need to update var latestStable = '1.0'; in versionwarning.js:

scikit-learn/scikit-learn.github.io@3d1baaa

@adrinjalali
Copy link
Member Author

the change is done now, was waiting for the builds to finish before pushing it

@adrinjalali
Copy link
Member Author

The fix the binder release version in .binder/requirement.txt doesn't seem to be required, right?

@thomasjpfan
Copy link
Member

From #14832 I think we do not need to update it anymore and it could be removed from the checklist.

@ogrisel
Copy link
Member
ogrisel commented Sep 24, 2021

I think we can close this one. Thanks everyone and @adrinjalali in particular!

@ogrisel ogrisel closed this as completed Sep 24, 2021
@GaelVaroquaux
Copy link
Member
GaelVaroquaux commented Sep 24, 2021 via email

@reshamas
Copy link
Member

@adrinjalali
In the checklist above, can we add an item: "share announcement with NumFOCUS for newsletter"

(I assume this checklist will be used for the next release.)

@adrinjalali
Copy link
Member Author

Arliss from NumFocus sends reminders before each newsletter, we just need to respond to those.

@LysandreJik LysandreJik mentioned this issue Aug 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
7 participants
@ogrisel @GaelVaroquaux @adrinjalali @reshamas @thomasjpfan @glemaitre @tupui
0