10000 ENH Checks n_features_in_ after fitting in mixture by thomasjpfan · Pull Request #19540 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Checks n_features_in_ after fitting in mixture #19540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2021
Merged

ENH Checks n_features_in_ after fitting in mixture #19540

merged 4 commits into from
Mar 23, 2021

Conversation

thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Feb 24, 2021 •
edited by ogrisel
Loading

Reference Issues/PRs

Related to #19333

What does this implement/fix? Explain your changes.

Checks n_features_in_ after fitting in mixture module.

Any other comments?

I also moved the self.component validation to fit, since this is the only time it is called.

@thomasjpfan thomasjpfan mentioned this pull request Feb 24, 2021
Closed
47 tasks
@ogrisel ogrisel mentioned this pull request Feb 25, 2021
Closed
ogrisel
ogrisel approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jeremiedbb
jeremiedbb approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Shouldn't the doc of n_features_in_ be done in this PR for (Bayesian)GaussianMixture ?

@thomasjpfan
Copy link
Member Author

Added the attribute to the docstring. Note that the versionadded is 0.24, because n_features_in_ is first introduced in 0.24.

@jeremiedbb
Copy link
Member

Thanks @thomasjpfan !

@jeremiedbb jeremiedbb merged commit cf296c7 into scikit-learn:main Mar 23, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:mixture No Changelog Needed Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @jeremiedbb @ogrisel
0