8000 [CI] changelog check failing on PR with unresolved conflicts · Issue #19559 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[CI] changelog check failing on PR with unresolved conflicts #19559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ogrisel opened this issue Feb 25, 2021 · 5 comments
Closed

[CI] changelog check failing on PR with unresolved conflicts #19559

ogrisel opened this issue Feb 25, 2021 · 5 comments
Labels
Bug Build / CI

Comments

@ogrisel
Copy link
Member
ogrisel commented Feb 25, 2021 •
edited
Loading

For instance: #19540 fails with:

https://github.com/scikit-learn/scikit-learn/pull/19540/checks?check_run_id=1977937609

Run echo "PR_NUMBER=19540" >> $GITHUB_ENV
  echo "PR_NUMBER=19540" >> $GITHUB_ENV
  echo "TAGGED_MILESTONE= >> $GITHUB_ENV
  shell: /usr/bin/bash -e {0}
/home/runner/work/_temp/6f19004d-8375-4b36-bace-92557dca6c17.sh: line 2: unexpected EOF while looking for matching `"'
Error: Process completed with exit code 2.

while it passed on other PRs without conflicts. Hence I suspect that the conflicts are causing this but I am not 100% sure.

Something weird: this check should be skipped because it is labeled "No Changelog Needed". I edited the PR description to make sure that the PR was labeled prior to re-running the changelog check and it's still failing with the above message.

/cc @cmarmo
@ogrisel
Copy link
Member Author
ogrisel commented Feb 25, 2021

Actually echo "TAGGED_MILESTONE= >> $GITHUB_ENV does not look right. But the source code seems good:

https://github.com/scikit-learn/scikit-learn/blob/main/.github/workflows/check-changelog.yml#L17

@cmarmo
Copy link
Contributor
cmarmo commented Feb 25, 2021

The typo fixed by f2943c6 is back... :( sorry

@ogrisel
Copy link
Member Author
ogrisel commented Feb 25, 2021

After merging main into the PR branch, the problem disappeared: the check-changelog check is now skipped in #19540...

@ogrisel
Copy link
Member Author
ogrisel commented Feb 25, 2021 •
edited
Loading

The typo fixed by f2943c6 is back... :( sorry

It's weird, I thought github actions would always use the workflow definition of the main branch... Anyway there is probably nothing else to do beyond merging the main branch into the PR branch if this failure happens again then.

@ogrisel
Copy link
Member Author
ogrisel commented Feb 25, 2021

We can probably close this issue.

@ogrisel ogrisel closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Build / CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ogrisel @cmarmo
0