8000 CI Check only title for regex labeling by thomasjpfan · Pull Request #19303 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Check only title for regex labeling #19303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2021
Merged

CI Check only title for regex labeling #19303

merged 3 commits into from
Feb 1, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #19266

What does this implement/fix? Explain your changes.

This allows us to control github actions through python and not yaml files using other projects.

@thomasjpfan thomasjpfan mentioned this pull request Jan 29, 2021
Closed
ogrisel
ogrisel approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

alfaro96
alfaro96 approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member
@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thomasjpfan!

LGTM.

Note: Could you modify the title of this PR to trigger the workflow and check if the proposed solution works?

@thomasjpfan
Copy link
Member Author

Since this is a pull_request_target event target, this PR can not trigger the workflow.

I've been testing this in a fork I placed in an organization here: thomasjpfan-actions-playground#3 . You can see how updating the title also updates the label. Here is a link to the workflow running on the PR.

rth
rth approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@rth rth merged commit 3325c23 into scikit-learn:main Feb 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@thomasjpfan @glemaitre
CI Check only title for regex labeling (scikit-learn#19303)
75a161a
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@thomasjpfan @glemaitre
CI Check only title for regex labeling (#19303)
8f2e39e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@rth rth rth approved these changes

@alfaro96 alfaro96 alfaro96 approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @ogrisel @rth @alfaro96
0