8000 [NOMRG] Check labeling as Build by cmarmo · Pull Request #19266 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[NOMRG] Check labeling as Build< 8000 /bdi> #19266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[NOMRG] Check labeling as Build #19266

wants to merge 1 commit into from

Conversation

cmarmo
Copy link
Contributor
@cmarmo cmarmo commented Jan 25, 2021

Check if the Build label is applied when CI is in the description of the PR.
See #19262

@cmarmo
Copy link
Contributor Author
cmarmo commented Jan 25, 2021

In labeler.yml the string CI is searched to label the PR.
I thought the search was performed only in the title... apparently the regexp is performed in the description too... is that normal?
cc @thomasjpfan ... Let's consider this one as an issue, do you mind?

@thomasjpfan thomasjpfan mentioned this pull request Jan 29, 2021
Merged
@thomasjpfan
Copy link
Member

Based on the READMe of the github action we are using: https://github.com/jimschubert/labeler-action

values are array of string patterns to match against title + body in issues/prs

This looks to be expected behavior.

I opened #19303 to use a simple python script that will allow us to control for this behavior.

@cmarmo cmarmo closed this Feb 8, 2021
@cmarmo cmarmo deleted the check-labeling branch August 26, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmarmo @thomasjpfan
0