8000 MNT skip preprocessing.rst when pandas is not installed by glemaitre · Pull Request #19016 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT skip preprocessing.rst when pandas is not installed #19016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2020
Merged

MNT skip preprocessing.rst when pandas is not installed #19016

merged 6 commits into from
Dec 18, 2020

Conversation

glemaitre
Copy link
Member

Try to fix master by installing pandas.

@ogrisel
Copy link
Member
ogrisel commented Dec 16, 2020

Out of curiosity do you have a direct URL of the CI failure?

@glemaitre
Copy link
Member Author

https://app.circleci.com/jobs/github/scikit-learn/scikit-learn/127838

Uhm it seems that we don't launch pypy on the PR. I have to find the flag then.

@alfaro96
Copy link
Member

We do not have a flag for pypy. I think that you need to comment these lines:

scikit-learn/.circleci/config.yml

Lines 159 to 165 in 38b7155

triggers:
- schedule:
cron: "0 0 * * *"
filters:
branches:
only:
- master

to test the PR.

@glemaitre
Copy link
Member Author

Thanks, I was starting the read the documentation.
It might be useful to have it as a flag at least because pushing into master to check if we solve the issue is not the best :)

@glemaitre
Copy link
Member Author
glemaitre commented Dec 16, 2020 •
edited
Loading

Uhm why do we have the following:

      - pypy3:
          filters:
            branches:
              only:
                - 0.20.X

I mean this is weird to only test branches only on 0.20.X

@alfaro96
Copy link
Member

Thanks, I was starting the read the documentation.

AFAIK, we do not have information in the documentation of how to trigger the pypy build (which is a little bit weird).

It might be useful to have it as a flag at least because pushing into master to check if we solve the issue is not the best :)

FYI: #13023.

@glemaitre
Copy link
Member Author

Thanks. I will just manually that pypy is working and I will take over #13023 to address the concern of @ogrisel

@glemaitre
Copy link
Member Author

This was my feeling. Pandas does not work well in PyPy

@glemaitre
Copy link
Member Author

we should probably skip the line then

@glemaitre
Copy link
Member Author

So I marked to skip to part where Pandas is required.

@glemaitre glemaitre changed the title MNT install pandas on pypy build MNT skip preprocessing.rst when pandas is not installed Dec 16, 2020
@glemaitre
Copy link
Member Author

I change the strategy to be consistent with the current pattern that is to skip the .rst files when pandas is required but not installed.

thomasjpfan
thomasjpfan approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is slightly disappointing that we have to turn off doctests because there was a new section using pandas.

Codewise this LGTM

@glemaitre
Copy link
Member Author

It is slightly disappointing that we have to turn off doctests because there was a new section using pandas.

Be aware that it happens only on some of the builds. Basically, we still test the doctests and this file on the build where pandas is installed.

@thomasjpfan
Copy link
Member

I am aware, especially when writing docs. I have been trying to avoid using new optional dependencies when writing the docs because of the need to skip.

However, I think it's not too bad to skip for this PR.

ogrisel
ogrisel approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel
Copy link
Member
ogrisel commented Dec 18, 2020

It is slightly disappointing that we have to turn off doctests because there was a new section using pandas.

We could move the new section to a dedicated .rst to be included by preprocessing.rst if we really want to avoid that, but I don't think it's worth the effort.

@ogrisel ogrisel merged commit 51bd343 into scikit-learn:master Dec 18, 2020
@ogrisel
Copy link
Member
ogrisel commented Dec 18, 2020

BTW, I think we should not run the doctests on the pypy build. The pypy build is already much to slow. It's just a waste of resource.

The primary goal of the doctests it to make sure that the inline examples are up to date with respect of the rest of the code base and this is already checked by running the doctests on the default CPython jobs.

@glemaitre
Copy link
Member Author
glemaitre commented Dec 18, 2020 via email

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@glemaitre
MNT skip preprocessing.rst when pandas is not installed (scikit-learn…
ca2e20e 
…#19016)
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@glemaitre
MNT skip preprocessing.rst when pandas is not installed (scikit-learn…
4b88e1a 
…#19016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glemaitre @ogrisel @alfaro96 @thomasjpfan
0