8000 MNT skip preprocessing.rst when pandas is not installed by glemaitre · Pull Request #19016 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT skip preprocessing.rst when pandas is not installed #19016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2020
Merged

MNT skip preprocessing.rst when pandas is not installed #19016

merged 6 commits into from
Dec 18, 2020

Conversation

glemaitre
Copy link
Member

Try to fix master by installing pandas.

@ogrisel
Copy link
Member
ogrisel commented Dec 16, 2020

Out of curiosity do you have a direct URL of the CI failure?

@glemaitre
Copy link
Member Author

https://app.circleci.com/jobs/github/scikit-learn/scikit-learn/127838

Uhm it seems that we don't launch pypy on the PR. I have to find the flag then.

@alfaro96
Copy link
Member

We do not have a flag for pypy. I think that you need to comment these lines:

scikit-learn/.circleci/config.yml

Lines 159 to 165 in 38b7155

triggers:
- schedule:
cron: "0 0 * * *"
filters:
branches:
only:
- master

to test the PR.

@glemaitre
Copy link
Member Author

Thanks, I was starting the read the documentation.
It might be useful to have it as a flag at least because pushing into master to check if we solve the issue is not the best :)