8000 [MRG+1] MNT fix E731 by lorentzenchr · Pull Request #16786 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] MNT fix E731 #16786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

[MRG+1] MNT fix E731 #16786

merged 2 commits into from
Mar 30, 2020

Conversation

lorentzenchr
Copy link
Member

What does this implement/fix? Explain your changes.

This PR fixes some E731 linter warnings.

@lorentzenchr
Copy link
Member Author

I hope the test failure is unrelated to this PR.

rth
rth approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, I never really understood/agreed with the issue about assigning labmba functions style wise, and one line functions is not much better IMO (while multiline functions would be somewhat verbose).

Sill LGTM, given that we address linter errors.

The failing check seems to fail because runtime is different, possibly after #16777

Could you re-trigger CI to see it's reproducible (git commit --allow-empty)? In any case we would likely need to fix that check in some other PR.

@lorentzenchr
Copy link
Member Author

As a side note, I never really understood/agreed with the issue about assigning labmba functions style wise, and one line functions is not much better IMO (while multiline functions would be somewhat verbose).

At least, my editor will show no more linter errors:smirk:

@lorentzenchr lorentzenchr changed the title [MRG] MNT fix E731 [MRG+1] MNT fix E731 Mar 30, 2020
@rth
Copy link
Member
rth commented Mar 30, 2020

Merging thanks! Just FYI, we generally try to avoid cosmetic changes as it has the potential to create conflicts in PRs #11336 .

@rth rth merged commit a2ccc33 into scikit-learn:master Mar 30, 2020
@lorentzenchr lorentzenchr deleted the e731 branch March 31, 2020 17:47
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@gio8tisu
STY PEP8 fix E731 in linear_model/_logistic.py (scikit-learn#16786)
c10a1b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
module:linear_model module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentzenchr @rth
0