8000 [MRG] MNT remove coupling between pipeline methods by NicolasHug · Pull Request #16777 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] MNT remove coupling between pipeline methods #16777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2020
Merged

[MRG] MNT remove coupling between pipeline methods #16777

merged 1 commit into from
Mar 27, 2020

Conversation

NicolasHug
Copy link
Member
@NicolasHug NicolasHug commented Mar 27, 2020 •
edited
Loading

Added a _check_fit_params method to consistently validate fit params.

Previously we were relying on _fit to return the fit_params of the last step (when it exists).

8000
@NicolasHug NicolasHug changed the title [WIP] MNT remove coupling between pipeline methods [MRG] MNT remove coupling between pipeline methods Mar 27, 2020
@NicolasHug
Copy link
Member Author

maybe @rth and @thomasjpfan ?

rth
rth approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall sounds good, but I'm not that familiar with the pipeline code so a second thorough review would be good.

TomDLT
TomDLT reviewed Mar 27, 2020
View reviewed changes
TomDLT
TomDLT approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member
@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomDLT TomDLT merged commit 88ce8cd into scikit-learn:master Mar 27, 2020
@pwl pwl mentioned this pull request Apr 8, 2020
Closed
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@NicolasHug @gio8tisu
MNT remove coupling between pipeline methods (scikit-learn#16777)
15df51e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
module:pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @rth @TomDLT
0