8000 warning for old version(0.8) by jaquesgrobler · Pull Request #1540 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

warning for old version(0.8) #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2013
Merged

warning for old version(0.8) #1540

merged 2 commits into from
Jan 11, 2013

Conversation

jaquesgrobler
Copy link
Member

Add a warning banner for older version

@jaquesgrobler
Copy link
Member Author

For issue #1533

@amueller
Copy link
Member
amueller commented Jan 8, 2013

Erm... there might be a misunderstanding... How will this work? You can not push the stuff to master. All websites except the dev docs are static. You have to push the generated files to sourceforge :-/ I'm not sure if you have the rights but I'm happy to give them to you.

@amueller
Copy link
Member
amueller commented Jan 8, 2013

oh, ok that is actually good ....

@amueller
Copy link
Member
amueller commented Jan 8, 2013

pushing to these branches makes sense. still it doesn'f fix the 8000 websites that are currently online.
It would be pretty sweet if we had a bot to take the tags and build documentation for each tag and upload it. But currently that was/is the job of Fabian, Gael and me ;)

@jaquesgrobler
Copy link
Member Author

Haha okay.. so we can't just update the old docs(currently online ones) from these branches?
Regarding the bots/tags, You, Gael or Fabian would have to school me on that a bit haha, then I'd do it gladly :)

@amueller
Copy link
Member
amueller commented Jan 8, 2013

Well in principal it is simple: make sure the docs look good an all examples are plotted (look at the exmples gallery).
Then upload the "_build/html" folder to sourceforge.
There is a file in doc/README thta explains how do upload to sourceforge. First, you have to create a sourceforge account. Then I can add you to the project.
Then you can rsync so sourceforge like so:
rsync youraccount,scikit-learn@web.sourceforge.net:htdocs/ -essh
which will show you a list of all the documenation folders. Then you can upload.

@jaquesgrobler
Copy link
Member Author

alright.. I'll have a look. Just trying to figure out why version 11 is refusing to display the banner now 😠
once they all look good I'll try the sourceforge upload. I'll keep you posted

@amueller
Copy link
Member
amueller commented Jan 8, 2013

awesome, thanks :)

@jaquesgrobler
Copy link
Member Author

Hey Andy.. eish, i've got a problem.. The banner is refusing to display on version 11 and onwards.. 10 and lower @jakevdp 's code takes care of it.. I've played around there a good while now and I just can't seem to figure out why it wont display.
I can make it display by removing the if statement in layout.html.. so it seems to fail the
{%- if theme_oldversion|tobool %} or alternatively {%- if theme_oldversion == true %}.. which is weird because oldversion = True in theme.conf.. I guess what is working on older versions doesn't work on 11 and onwards..
I'm gonna put this on pause for now and give it a bit of a bash again later or so.Let me know if you can think of anything :)

@amueller
Copy link
Member
amueller commented Jan 8, 2013

Sorry, I'm really not familiar with this. Thanks for giving it a shot. Maybe @jakevdp can comment?

@jaquesgrobler
Copy link
Member Author

Haha yeah, I tagged him in my previous comment on purpose :trollface:

@jakevdp
Copy link
Member
jakevdp commented Jan 8, 2013

DId you also set oldversion=True in conf.py? This overrides the default in theme.conf.

@jakevdp
Copy link
Member
jakevdp commented Jan 8, 2013

If that's the case, I think it would be better to leave the default set to False in theme.conf, and adjust the parameter via conf.py.

Edit: I took a look at the PRs, and I'm pretty sure this is the issue. In theme.conf, the default for oldversion should be false, and the default should be overridden and set to true in doc/conf.py. That way all that needs to happen when a new version is released is to change the conf.py behavior in the newly deprecated version.

@jaquesgrobler
Copy link
Member Author

Ahh okay thanks jake, Iĺl check this out :)

@jaquesgrobler
Copy link
Member Author

Haha, @jakevdp thanks a lot that fixes it.. Just updating then I'll move this along. Thanks again

@jaquesgrobler
Copy link
Member Author

@amueller - alright, so I'm ready to get this going onto sourceforge .. I've sent you my details so you can add me to project. Then I'll get the updating going

@amueller
Copy link
Member

Thanks. Where / when did you sent them? I didn't see anything.

@jaquesgrobler
Copy link
Member Author

Haha, on your Google+ account.. couldn't find your email quickly enough

2013/1/10 Andreas Mueller notifications@github.com

Thanks. Where / when did you sent them? I didn't see anything.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1540#issuecomment-12096865.

@amueller
Copy link
Member

lol. I have been known to post on the sklearn ML sometimes ;)

@amueller
Copy link
Member

I added you to the project as admin :) (hope that was ok @GaelVaroquaux)

@jaquesgrobler
Copy link
Member Author

Okay cool - shall I merge these old branches in?

@GaelVaroquaux
Copy link
Member

Okay cool - shall I merge these old branches in?

Try it. If you feel unsure about what you are doing, ask @fabianp

@jaquesgrobler
Copy link
Member Author

@GaelVaroquaux okay thanks :)

@jaquesgrobler
Copy link
Member Author

Okay got it.. here's version 0.6 with banner.. doing the rest now

@jaquesgrobler jaquesgrobler mentioned this pull request Jan 10, 2013
Closed
@jaquesgrobler
Copy link
Member Author

as I mentioned on that reference - there is version 0.7 folder on htdocs.. I'm gonna continue onto 0.8 etc. for now

@amueller
Copy link
Member

THANK YOU SO MUCH!
That was a typo above, you mean there is no 0.7 folder, right?
I think it would be good to push it if you are at it. Someone somewhere might have that installed ;)
Also there are some dead links to it.

@amueller
Copy link
Member

not bad at all!

@jaquesgrobler
Copy link
Member Author

haha yeah.. typo.. and I did it twice!

K, version 0.7 is back up 💃
Doing the last few now.. After these guys are done, shall I merge those other PR's (like this one) into their respective branches?

@amueller
Copy link
Member

Yeah, I think it's ok to do that. good for future reference and if you could build the docs it should be fine.

@ogrisel
Copy link
Member
ogrisel commented Jan 10, 2013

+1, thanks @jaquesgrobler!

@jakevdp
Copy link
Member
jakevdp commented Jan 11, 2013

+1 for merging these as well. Nice work Jaques!

@GaelVaroquaux
Copy link
Member

Yeah, this is a great. Thanks a lot to all involved

@GaelVaroquaux
Copy link
Member

Yeah, this is a great. Thanks a lot to all involved

I just noticed that 0.10 and 0.11 do not have the warning banner. Is
there a reason for that?

@jaquesgrobler
Copy link
Member Author

10 has now.. my internet bombed last night so couldn't finish those two.. 11 loading :)

A211
@jaquesgrobler
Copy link
Member Author

Okay.. i checked again - all of them are up. Merging these other branches

jaquesgrobler added a commit that referenced this pull request Jan 11, 2013
@jaquesgrobler
Merge pull request #1540 from jaquesgrobler/warn08
9aae3b3 
warning for old version(0.8)
@jaquesgrobler jaquesgrobler merged commit 9aae3b3 into scikit-learn:0.8.X Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaquesgrobler @amueller @jakevdp @GaelVaroquaux @ogrisel
0