8000 GridsearchCV does not work with mix of floats + None for LogisticRegression · Issue #1533 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

GridsearchCV does not work with mix of floats + None for LogisticRegression #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RONNCC opened this issue Jan 7, 2013 · 21 comments
Closed

GridsearchCV does not work with mix of floats + None for LogisticRegression #1533

RONNCC opened this issue Jan 7, 2013 · 21 comments
Labels
Bug Documentation

Comments

@RONNCC
Copy link
RONNCC commented Jan 7, 2013

When i set C =
'C':[.01,.1,10,20,30,40,50,100,None], or 'C':[None,.01,.1,10,20,30,40,50,100], it complains C must be a float. Yet 'C':[.01,.1,10,20,30,40,50,100] works.

It does not seem to parse out the None correctly?
@amueller
Copy link
Member
amueller commented Jan 8, 2013

I don't understand. C must be a float. What is None supposed to mean?

@amueller amueller closed this as completed Jan 8, 2013
@amueller
Copy link
Member
amueller commented Jan 8, 2013

Please let me know if we can improve the documentation somehow. To me "C must be a float" is quite explicit.

@RONNCC
Copy link
Author
RONNCC commented Jan 8, 2013

The docs say that C if not set as a float is by default None which means it is set to n_samples

@amueller
Copy link
Member
amueller commented Jan 8, 2013

Really? oh, sorry. I think this is a mistake in the docs.

@amueller amueller reopened this Jan 8, 2013
@RONNCC
Copy link
Author
RONNCC commented Jan 8, 2013

the docs say that C = None as the default init setting ...

On Tue, Jan 8, 2013 at 3:34 AM, Andreas Mueller notifications@github.comwrote:

Really? oh, sorry. I think this is a mistake in the docs.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1533#issuecomment-11988673.

@amueller
Copy link
Member
amueller commented Jan 8, 2013

Where?
Neither in the dev nor the stable as far as I can tell.

@RONNCC
Copy link
Author
RONNCC commented Jan 8, 2013

... oh sorry, I accidentally was looking at the wrong version >___<

http://scikit-learn.org/0.11/modules/generated/sklearn.linear_model.LogisticRegression.html

@amueller
Copy link
Member
amueller commented Jan 8, 2013

No problem. We wanted to put a warning banner on all old versions but somehow that never got done :(

@amueller amueller closed this as completed Jan 8, 2013
@jaquesgrobler
Copy link
Member

There is a warning banner there on the top left :)

@amueller
Copy link
Member
amueller commented Jan 8, 2013

That is not really a warning. That is there in all versions.
There is a red banner over all of the top hidden in the CSS / website options but I never got the nerve to rebuild all of the docs.

@RONNCC
Copy link
Author
RONNCC commented Jan 8, 2013

a bigger one would be nice >____< maybe something like
http://docs.pythonsprints.com/python3_porting/py-porting.html except saying
"Deprecated" like
http://docs.python.org/2/library/string.html#deprecated-string-functions ?

On Tue, Jan 8, 2013 at 4:11 AM, Jaques Grobler notifications@github.comwrote:

There is a warning banner there on the top left :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1533#issuecomment-11989624.

@jaquesgrobler
Copy link
Member

Hmm.. that would be nice (@RONNCC 's suggestion)..
I'll have a look-see

@amueller
Copy link
Member
amueller commented Jan 8, 2013

@jaquesgrobler as I said, there is an option in the doc config to include a banner. @jakevdp coded it I think.
It is "just" a matter of setting the flag, rebuilding the docs for all old version and uploading them. It would be great if you could do it.

@amueller
Copy link
Member
amueller commented Jan 8, 2013

see #640 ;)

@jaquesgrobler
Copy link
Member

Just getting a ☕ then I'm on it

@amueller
Copy link
Member
amueller commented Jan 8, 2013

The config flag is in doc/themes/scikit-learn/theme.conf.

@jaquesgrobler
Copy link
Member

Just building etc. Will check the docs and then submit :)

@jaquesgrobler
Copy link
Member

Hey Andy - just built version 11 with that flag(oldversion) tuned to True, aber ich kann nichts sehen... No warning block anywhere.. I'm gonna go eat in a tick, then I'll have a look why.. The code in layout.html suggests that it should provide the desired effect.. I'll have a thorough look when I get back

{% block header %}
   {%- if theme_oldversion == true %}
     <div class="warning-wrapper">
       <p>Warning: This documentation is
         for {{project}} <strong>version {{ release|e }}</strong>.
         &mdash; <a href="http://scikit-learn.org/stable/">
           Latest stable version</a></p></p>
     </div>
   {%- endif %}

@amueller
Copy link
Member
amueller commented Jan 8, 2013

Didn't know you spoke German. Not bad :)
We had it working at some point, I never played with it so. Guten appetit ;)

@jaquesgrobler
Copy link
Member

haha, not very well.. understand more than I speak.. nonetheless.. Think I've got it working now.. just checking it again..watch this space 😄

@jaquesgrobler jaquesgrobler mentioned this issue Jan 8, 2013
Merged
@jaquesgrobler
Copy link
Member

that's for 9.
doing others quick

This was referenced Jan 8, 2013
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amueller @RONNCC @jaquesgrobler
0