8000 TfidfVectorizer, CountVectorizer fixed_vocabulary_ documentation by mandalbiswadip · Pull Request #14372 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TfidfVectorizer, CountVectorizer fixed_vocabulary_ documentation #14372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2019
Merged

TfidfVectorizer, CountVectorizer fixed_vocabulary_ documentation #14372

merged 2 commits into from
Jul 15, 2019

Conversation

mandalbiswadip
Copy link
Contributor

Partially address #14312 and covers TfidfVectorizer, [fixed_vocabulary_]

I think the same attribute is used in CountVectorizer

rth
rth reviewed Jul 15, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines should be less than 80 char long (need to add a line break). Otherwise LGTM. Thanks!

@mandalbiswadip
Copy link
Contributor Author

@rth appreciate your feedback. Have made the necessary commits again.

qinhanmin2014
qinhanmin2014 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mandalbiswadip

@qinhanmin2014 qinhanmin2014 merged commit ef8e3c9 into scikit-learn:master Jul 15, 2019
@mandalbiswadip mandalbiswadip deleted the TfidfVectorizer_fixed_vocabulary_attribute branch July 15, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth left review comments

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

 377D
3 participants
@mandalbiswadip @rth @qinhanmin2014
0