8000 Readability of the image by color blind persons (#wimlds) (#14154) by lagvier · Pull Request #14160 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Readability of the image by color blind persons (#wimlds) (#14154) #14160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lagvier
Copy link
Contributor
@lagvier lagvier commented Jun 22, 2019

Reference Issues/PRs

Fixes for: #14154.

Implemented for:

Contrast image colors for readability by color-blind for documentation file https://scikit-learn.org/dev/auto_examples/preprocessing/plot_map_data_to_normal.html

Image before:
image

Image after:
image

Collaborators:

@felexkemboi, @mcecily, @toopurity, @martinoywa

@thomasjpfan
Copy link
Member

Is there a color palette with six different colors that is color-blind accessible that we can use here?

@rth
Copy link
Member
rth commented Jun 22, 2019

Also there are stalled PRs #5555 and #5538 that could be continued on thus topic. Maybe there are better colors there.

Could please also post the results with of "Let's Get Colorblind" firefox extension for before / after (or some equivalent tool)?

@rth
Copy link
Member
rth commented Jun 22, 2019

(Also when you make these PRs please link to the relevent issue #5435)

@lagvier
Copy link
Contributor Author
lagvier commented Jun 22, 2019

(Also when you make these PRs please link to the relevent issue #5435)

Also there are stalled PRs #5555 and #5538 that could be continued on thus topic. Maybe there are better colors there.

Could please also post the results with of "Let's Get Colorblind" firefox extension for before / after (or some equivalent tool)?

I manually confirmed with the link:

Also there are stalled PRs #5555 and #5538 that could be continued on thus topic. Maybe there are better colors there.

Could please also post the results with of "Let's Get Colorblind" firefox extension for before / after (or some equivalent tool)?

The adjacent similarity for the green-blind from "Let's Get Colorblind" extension: The other color blind categories shows distinction of adjacent colors

Before:
image

After:
image

@jnothman
Copy link
Member
jnothman commented Jun 23, 2019 via email

@glemaitre
Copy link
Member

@mpetroff opened and work on an issue in matplotlib: matplotlib/matplotlib#9460

We might want to have a look there to see if we can pick-up a cycle which works best until one is landing in matplotlib.

@rth rth closed this in #14173 Jun 24, 2019
@mpetroff
Copy link

Preliminary analysis [1] [2] of my color cycle survey data yielded the following cycle:
#dc89fb, #097b36, #88749d, #c6d5cf, #61fc51, #3fb926

However, as this analysis is preliminary, I can't fully recommend it, at least from an aesthetic perspective. Minimum perceptual distance, including color vision deficiency simulation, was enforced when generating the color sets, so it should be colorblind-safe.

For this particular plot, I don't think the color is much a problem, since the groupings can be deduced from the subplot structure. This could be improved by increasing the space between the groups of subplots, such that the grouping would be obvious even if all 24 histograms were the same color.

@glemaitre
Copy link
Member

@mpetroff Thanks for the input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0