8000 EXA Readability of plot_isotonic_regression.py for color blind persons by lagvier · Pull Request #14154 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

EXA Readability of plot_isotonic_regression.py for color blind persons #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2019
Merged

EXA Readability of plot_isotonic_regression.py for color blind persons #14154

merged 1 commit into from
Jun 22, 2019

Conversation

lagvier
Copy link
Contributor
@lagvier lagvier commented Jun 22, 2019

Reference Issues/PRs:

@adrinjalali
Copy link
Member

Related to #5435

could you please post the image result before and after the change?

@lagvier
Copy link
Contributor Author
lagvier commented Jun 22, 2019

Before: Color red and blue not differentiated by red-green blindness
image

After: Changed to green to yellow for readability
image

adrinjalali
adrinjalali approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lagvier :)

lagvier added a commit to lagvier/scikit-learn that referenced this pull request Jun 22, 2019
@lagvier
Readability of the image by color blind persons (#wimlds) (scikit-lea…
86111b8 
…rn#14154)
@lagvier lagvier mentioned this pull request Jun 22, 2019
Closed
@rth
Copy link
Member
rth commented Jun 22, 2019

Could please also post screenshots with of "Let's Get Colorblind" firefox extension for before / after (or some equivalent tool)?

@lagvier
Copy link
Contributor Author
lagvier commented Jun 22, 2019

Could please also post screenshots with of "Let's Get Colorblind" firefox extension for before / after (or some equivalent tool)?

The Let's Get Colorblind results. The concern with the green-blind differences
Blue-blind:
Before
image
After
image

Green-blind
Before
image

After
image

Red-Blind
Before
image

After
image

rth
rth approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lagvier!

@rth rth changed the title Readability of the image by color blind persons (#wimlds) EXA Readability of plot_isotonic_regression.py for color blind persons Jun 22, 2019
@rth rth merged commit a31676b into scikit-learn:master Jun 22, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@lagvier @koenvandevelde
EXA Readability of plot_isotonic_regression.py for color blind persons (
788f4ce 
scikit-learn#14154)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 29, 2019
@lagvier @jnothman
EXA Readability of plot_isotonic_regression.py for color blind persons (
a3344f9 
scikit-learn#14154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lagvier @adrinjalali @rth
0