8000 [MRG] Fix OpenMP runtime error on mac by jeremiedbb · Pull Request #13294 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Fix OpenMP runtime error on mac #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2019
Merged

[MRG] Fix OpenMP runtime error on mac #13294

merged 3 commits into from
Feb 27, 2019

Conversation

jeremiedbb
Copy link
Member

Avoids runtime error from OpenMP due to multiple OpenMP runtime libs loaded simultaneously.
Happens when calling BLAS inside prange parallel loop.
Happens only on mac...

ping @ogrisel

ogrisel
ogrisel approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe we can just extend the comment to make it even more explicit that we handle oversubscription by manually reconfiguring the inner OpenMP loops.

@ogrisel
Copy link
Member
ogrisel commented Feb 27, 2019

Any idea why circleci is killed like that?

@jeremiedbb
Copy link
Member Author

No idea but we've already seen this failure last week, right ?

@glemaitre
Copy link
Member

Related to OpenML/ARFF reader taking too much memory: #13287

glemaitre
glemaitre reviewed Feb 27, 2019
View reviewed changes
glemaitre
glemaitre approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nitpick. @jeremiedbb I will merge once you corrected it.

@jeremiedbb jeremiedbb force-pushed the fix-macos-openmp-runtimes branch from 482f8e9 to 33c46df Compare February 27, 2019 14:14
@jeremiedbb jeremiedbb mentioned this pull request Feb 27, 2019
Closed
@jeremiedbb
Copy link
Member Author

@glemaitre the travis failure seems unrelated. It's a http error.

@glemaitre glemaitre merged commit ffd27c8 into scikit-learn:master Feb 27, 2019
@glemaitre
Copy link
Member

Thanks

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@jeremiedbb
MAINT: Fix OpenMP runtime error on mac (scikit-learn#13294)
59f5b41
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MAINT: Fix OpenMP runtime error on mac (scikit-learn#13294)"
b5bf64a 
This reverts commit 59f5b41.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MAINT: Fix OpenMP runtime error on mac (scikit-learn#13294)"
c764cb5 
This reverts commit 59f5b41.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jeremiedbb @koenvandevelde
MAINT: Fix OpenMP runtime error on mac (scikit-learn#13294)
c8e2ed1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @ogrisel @glemaitre
0