8000 CircleCI keeps failing on master · Issue #13287 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CircleCI keeps failing on master #13287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrinjalali opened this issue Feb 26, 2019 · 8 comments · Fixed by #13312
Closed

CircleCI keeps failing on master #13287

adrinjalali opened this issue Feb 26, 2019 · 8 comments · Fixed by #13312
Labels
Build / CI

Comments

@adrinjalali
Copy link
Member

Example failure: https://circleci.com/gh/scikit-learn/scikit-learn/48261?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification
@glemaitre
Copy link
Member

@jorisvandenbossche tracked the issue. This is due to a too large usage of memory. The example uses MNIST and it peaks to around 3 GB of memory locally. This is linked to the ARFF reader.

However, this is not a regression (it was already using that much in the past). Not sure if CircleCI changed the memory limitation for a node.

@glemaitre glemaitre mentioned this issue Feb 27, 2019
Merged
@adrinjalali
Copy link
Member Author

Do we really need that whole dataset for the purpose of this example? I personally wouldn't mind having it faster and smaller. Fixing arff reader (if that's possible/easy) would be an independent issue which we should also try to do.

@jorisvandenbossche jorisvandenbossche mentioned this issue Feb 27, 2019
Merged
@jorisvandenbossche
Copy link
Member

So the docs are still failing, but now with another error .. (a timeout: https://circleci.com/gh/scikit-learn/scikit-learn/49319)

@adrinjalali
Copy link
Member Author

yeah the timeout was there before too. It was just masked by the other error.

@cmarmo
Copy link
Contributor
cmarmo commented Feb 19, 2020

Is this issue still relevant? Thanks!

@alfaro96
Copy link
Member

I do not think so, since the pypy job is working on main.

Closing then @cmarmo?

@cmarmo
Copy link
Contributor
cmarmo commented Mar 19, 2021

Yes @alfaro96! :) I'll let you close it?

@alfaro96
Copy link
Member

Closing then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Memory usage of OpenML fetcher: use generator from arff jorisvandenbossche/scikit-learn
5 participants
@jorisvandenbossche @cmarmo @adrinjalali @glemaitre @alfaro96
0