DOC Update changed models for 0.20.2 #12810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jnothman
reviewed
Dec 18, 2018
doc/whats_new/v0.20.rst
Outdated
| @@ -21,6 +21,10 @@ occurs due to changes in the modelling logic (bug fixes or enhancements), or in | |||
| random sampling procedures. | |||
|
|
|||
| - :mod:`sklearn.neighbors` when ``metric=='jaccard'`` (bug fix) | |||
| - :class:`metrics.pairwise_distances` when ``n_jobs > 1`` and | |||
There was a problem hiding this comment.
I hadn't expected this summary to include this much detail. Just say "use of 'seuclidean' or 'mahalanobis' metrics in some cases"..?
There was a problem hiding this comment.
Hmm, "in some cases", are you sure? I'll turn to your version so as not to block the release.
There was a problem hiding this comment.
Don't need to pander to me, but there's a proper list of changes below. This is only meant to be a summary, and really is not that important for regressions in minor versions.
There was a problem hiding this comment.
The point is also that it applies beyond just users of metrics.
jnothman
approved these changes
Dec 18, 2018
|
Let's just do this. |
jnothman
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 18, 2018
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Jan 7, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 1a3c9a4.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 1a3c9a4.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #12701 #12809
ping @jnothman @amueller