-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG] CI Add commit flag [nightly] to run travis with SciPy nightly builds #11377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ping @lesteve |
Right, I was probably running locally only the test that was expected to fail, sorry about that! Very nice about the commit thing in Travis, didn't know about this one! "nightly" sounds a bit vague to me, I would rather have something like "scipy-dev-wheels" or a improved name if you can think of one as long as it matches the DISTRIB environment variable in .travis.yml for this build. |
I'm fine with [scipy-dev-wheels]. I'd rather [scipy-dev]. I just thought I'd try for something a little memorable. |
dev-dependencies maybe (since we are installing numpy, scipy, cython and pandas) ? I have to admit, nightly reminds me too much of the days I was writing mostly C++ ;-) (or ;-( not sure). |
I might call it [bleeding edge], or just [bleeding] but perhaps we should
then also use the CPython bleeding edge (or highest version supported by
scipy)
|
For now it's [scipy-dev], and it's passing. So perhaps we should merge, silence CRON, and mull on whether there's a better name for the flag. |
scipy-dev is fine, sorry for the nitpicking. Let's do our best to call it scipy-dev in our issues as well! |
Merging, thanks a lot @jnothman! |
Unfortunately #11359 still didn't fix our builds on scipy nightly wheels (#11194).
This PR adds a commit message flag,
[nightly]
to trigger the Travis build otherwise only run on cron. I'll try to fix the remaining issues in this PR also.