[MRG] TST: fix scipy-dev-wheels build #11359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Jun 26, 2018
Root cause is numpy.matrix PendingDeprecationWarning
ca1ec4c to
6ec4866
Compare
|
I fixed the flake8 error. |
TomDLT
approved these changes
Jun 26, 2018
IIRC @jnothman mentioned somewhere (can't find the comment right now) that we should ignore warnings that comes from outside scikit-learn in our testing (or maybe only in warnings.filterwarning('always', module='^sklearn')
warnings.simplefilter('ignore') |
|
I think sometimes we will want to include, sometimes to exclude. the
problem with these warning assertions is that because they use **kw they're
not extensible. This is a benefit of pytest.warns, but it's more verbose
|
|
I would be in favour of merging this PR as is, similarly to what was done for the previous one (#11251). Although not ideal, I think this does fix the scipy-dev-wheels build. |
TomDLT
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11194 one more time ...
If this keeps happening I think we will need to have a better way of dealing with these.
I was expecting that
pytest.warnswould respectwarnings.filters(the matrix subclass is not the recommended wayis included inwarnings.filtersI double-checked) in contrary tosklearn.utils.testing.assert_no_warningswhich internally doeswarnings.simplefilter('always')(+some custom ignoring of np.VisibleDeprecationWarning). Apparently my expectation about the interaction ofpytest.warnsandwarnings.filtersis not correct ...