[MRG] Run make test-doc on scipy-dev-wheels build #10246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
FYI the Travis cron job ran fine and the doctests for the |
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
6170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since numpy/numpy#10059 has been fixed in numpy master, we can run the doctests on our doc with numpy dev failures.
This fixes #8959.
Here is a log of a scipy-dev-wheels cron job on my PR branch:
https://travis-ci.org/lesteve/scikit-learn/builds/311283367#L2460
This does show that doctests of the doc are run.
Note that the CI do not test anything and this PR will only be tested once merged and the Travis cron job runs.