8000 legacy 1.13 printing edge case: missing superfluous comma after ellipsis · Issue #10059 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

legacy 1.13 printing edge case: missing superfluous comma after ellipsis #10059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesteve opened this issue Nov 20, 2017 · 3 comments
Closed

legacy 1.13 printing edge case: missing superfluous comma after ellipsis #10059

lesteve opened this issue Nov 20, 2017 · 3 comments

Comments

@lesteve
Copy link
Contributor
lesteve commented Nov 20, 2017

I think this is the last quirk that we found when running the scikit-learn doctests. After this one you will hopefully not hear from me for a while ;-). We have only one doctest affected by this and we can work around this easily by using repr instead of print or using doctest ellipsis.

This edge case does break the legacy='1.13' promise so I thought I would let you know and then you can decide whether you want to fix it (i.e. match the buggy behaviour with legacy='1.13') or not. I would completely understand if you just decided to close this issue

import numpy as np

try:
    np.set_printoptions(legacy='1.13')
except TypeError:
    pass

print(np.arange(10000))

Output numpy dev:

[   0    1    2 ... 9997 9998 9999]

Ouput on 1.13.3 (note the additional comma after the ellipsis):

[   0    1    2 ..., 9997 9998 9999]
@eric-wieser
Copy link
Member
eric-wieser commented Nov 20, 2017 •
edited
Loading

Yep, this was issue #9777/PR #9815, which was before we settled on the legacy API, I think.

It's pretty straightforward to fix this, so I'm inclined to say we should, even if it was a bugfix.

@eric-wieser eric-wieser added this to the 1.14.0 release milestone Nov 20, 2017
This was referenced Nov 21, 2017
Closed
Merged
@charris
Copy link
Member
charris commented Nov 27, 2017

@ahaldane @eric-wieser Has this been fixed?

@eric-wieser
Copy link
Member

No, this is still outstanding

@ahaldane ahaldane mentioned this issue Nov 29, 2017
Merged
ahaldane added a commit to ahaldane/numpy that referenced this issue Nov 29, 2017
@ahaldane
BUG: stray comma should be preserved for legacy printing
b49b20f 
Fixes numpy#10059
@lesteve lesteve mentioned this issue Dec 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charris @eric-wieser @lesteve
0