8000 String to array comparison in RandomizedLasso · Issue #5725 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

String to array comparison in RandomizedLasso #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Nov 4, 2015 · 6 comments
Closed

String to array comparison in RandomizedLasso #5725

amueller opened this issue Nov 4, 2015 · 6 comments
Labels
Bug Easy Well-defined and straightforward way to resolve
Milestone
0.17.1

Comments

@amueller
Copy link
Member
amueller commented Nov 4, 2015

here: https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/randomized_l1.py#L333

if alpha in ('aic', 'bic')

This popped up in the examples, but not in the tests as far as I can tell. Which probably means it is not covered in the tests.
ping @agramfort ;)
@amueller
Copy link
Member Author
amueller commented Nov 4, 2015

[I don't tag this for the release because I want to release at some point]

@amueller amueller added the Bug label Nov 4, 2015
@agramfort
Copy link
Member
agramfort commented Nov 4, 2015 via email

@amueller
Copy link
Member Author
amueller commented Nov 4, 2015

yeah, but I thought it might be worth checking coverage.

@ghost
Copy link
ghost commented Nov 16, 2015

We will take a stab at this one at the code sprint (11-16-2015)

@amueller amueller added the Easy Well-defined and straightforward way to resolve label Nov 16, 2015
@ghost
Copy link
ghost commented Nov 16, 2015

also see #5413 (amueller)

@steph-query steph-query mentioned this issue Nov 26, 2015
Merged
@mrshu
Copy link
Contributor
mrshu commented Dec 15, 2015

@amueller since #5852 got merged should this issue be closed?

@TomDLT TomDLT closed this as completed Jan 4, 2016
@ogrisel ogrisel added this to the 0.17.1 milestone Jan 27, 2016
ogrisel pushed a commit that referenced this issue Jan 27, 2016
@steph-query @ogrisel
fix for #5725 (makes sure numpy array is not compared to string, whic…
887a069 
…h will fail in future versions of numpy)
TomDLT pushed a commit to TomDLT/scikit-learn that referenced this issue Oct 3, 2016
@steph-query @TomDLT
fix for scikit-learn#5725 (makes sure numpy array is not compared to …
3b6683a 
…string, which will fail in future versions of numpy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
0.17.1
Development

No branches or pull requests
5 participants
@ogrisel @agramfort @amueller @mrshu @TomDLT
0