8000 [MRG + 1] remove string to array comparison in RandomizedLasso by steph-query · Pull Request #5852 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG + 1] remove string to array comparison in RandomizedLasso #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2015
Merged

[MRG + 1] remove string to array comparison in RandomizedLasso #5852

merged 1 commit into from
Dec 12, 2015

Conversation

steph-query
Copy link
Contributor

makes sure numpy array is not compared to string, which will fail in future versions of numpy
#5725

@steph-query
fix for #5725 (makes sure numpy array is not compared to string, whic…
998848a 
…h will fail in future versions of numpy)
@MechCoder
Copy link
Member

Can alpha be an array here? The documentation says it can just be a float.

@TomDLT TomDLT changed the title [MRG] fix for #5725 [MRG] remove string to array comparison in RandomizedLasso Nov 26, 2015
@TomDLT
Copy link
Member
TomDLT commented Nov 26, 2015

Could you add a test please?

@amueller
Copy link
Member

@TomDLT this is a deprecation, so I don't know what to test for. I feel like testing for not raising deprecation warnings in numpy is a bit too much. [unless doing it globally as I suggested in #5685]

@amueller
Copy link
Member

LGTM.

@amueller amueller changed the title [MRG] remove string to array comparison in RandomizedLasso [MRG + 1] remove string to array comparison in RandomizedLasso Dec 11, 2015
@TomDLT
Copy link
Member
TomDLT commented Dec 12, 2015

Ok, a test will make sense when Numpy breaks on this, but I guess it is nitpicking.
LGTM

TomDLT added a commit that referenced this pull request Dec 12, 2015
@TomDLT
Merge pull request #5852 from nickyj88/master
2f76310 
[MRG + 1] remove string to array comparison in RandomizedLasso
@TomDLT TomDLT merged commit 2f76310 into scikit-learn:master Dec 12, 2015
@mrshu mrshu mentioned this pull request Dec 15, 2015
Closed
@amueller amueller mentioned this pull request Jan 20, 2016
Merged
@ogrisel
Copy link
Member
ogrisel commented Jan 27, 2016

Backported to 0.17.X as 887a069.

@ogrisel ogrisel added this to the 0.17.1 milestone Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.1
Development

Successfully merging this pull request may close these issues.
5 participants
@steph-query @MechCoder @TomDLT @amueller @ogrisel
0