8000 Refrain from adding ctor to class from ct.sym by som-snytt · Pull Request #9981 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Refrain from adding ctor to class from ct.sym #9981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Refrain from adding ctor to class from ct.sym #9981

merged 2 commits into from
Apr 20, 2022

Conversation

som-snytt
Copy link
Contributor
@som-snytt som-snytt commented Mar 25, 2022 •
edited
Loading

Fixes scala/bug#12565

Tweak test for java annotation flag when parsing class file.

Previously, spurious constructors were added. Noticed when parsing .sig entry from ct.sym, which exposes only public API.

@scala-jenkins scala-jenkins added this to the 2.13.9 milestone Mar 25, 2022
@som-snytt som-snytt marked this pull request as ready for review March 26, 2022 00:40
lrytz
lrytz reviewed Mar 28, 2022
View reviewed changes
@som-snytt som-snytt mentioned this pull request Mar 28, 2022
Merged
@dwijnand dwijnand merged commit 2d651a6 into scala:2.13.x Apr 20, 2022
som-snytt
som-snytt commented Apr 20, 2022
View reviewed changes
@som-snytt som-snytt deleted the ready/12565 branch April 20, 2022 15:57
@Jasper-M Jasper-M mentioned this pull request Apr 26, 2022
Merged
@smarter smarter mentioned this pull request May 9, 2022
Closed
@som-snytt som-snytt mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz left review comments

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.9
Development

Successfully merging this pull request may close these issues.

-release 8 causes java.time.Instant to have a fictitious constructor
4 participants
@som-snytt @lrytz @dwijnand @scala-jenkins
0