Forward port java annotation handling #10032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
commented
May 10, 2022
src/compiler/scala/tools/nsc/symtab/classfile/ClassfileParser.scala
Outdated
Show resolved
Hide resolved
lrytz
approved these changes
May 10, 2022
som-snytt
commented
May 10, 2022
| @@ -865,7 +854,7 @@ abstract class ClassfileParser(reader: ReusableInstance[ReusableDataReader]) { | |||
| case tpnme.RuntimeAnnotationATTR => | |||
| val numAnnots = u2() | |||
| val annots = new ListBuffer[AnnotationInfo] | |||
| for (n <- 0 until numAnnots; annot <- parseAnnotation(u2())) | |||
| for (n <- 0 until numAnnots; annot <- parseAnnotation(u2())) | |||
There was a problem hiding this comment.
Distracted by indent, forgot to use fancy times.
som-snytt
commented
May 10, 2022
| @@ -1502,3 +1492,8 @@ abstract class ClassfileParser(reader: ReusableInstance[ReusableDataReader]) { | |||
| protected def getScope(flags: JavaAccFlags): Scope = | |||
| if (flags.isStatic) staticScope else instanceScope | |||
| } | |||
| object ClassfileParser { | |||
| private implicit class GoodTimes(val n: Int) extends AnyVal { | |||
| def times(body: => Unit) = (1 to n).foreach(_ => body) | |||
There was a problem hiding this comment.
Could have gone while here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improve
#9981
by forward porting
#10016
and then get carried away a bit with tweaks.