Add isFinite-method to RichDouble and RichFloat
#8104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang, there goes my first contribution 😄 Plus you did at least twice as good a job by not forgetting about |
lrytz
approved these changes
May 28, 2019
|
How was it possible to get merged now despite the byte-code incompatibility? Is this in foreknowledge of |
|
@otto-dev your PR was against 2.12, for which it is binary-incompatible. this PR is against 2.13, which is not yet released. additionally, it was not known at the time of your PR that there would definitely be an RC3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this PR is #8063 made against the
2.13branch with the addition of adding the method to RichFloat as well. Closes scala/bug#11531.