8000 Add .isFinite to RichDouble(_) by otto-dev · Pull Request #8063 · scala/scala · GitHub
[go: up one dir, main page]

Skip to content

Add .isFinite to RichDouble(_) #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add .isFinite to RichDouble(_) #8063

wants to merge 1 commit into from

Conversation

otto-dev
Copy link

Fixes scala/bug#11531. Rationale for this PR is outlined there.

Full text search for RichDouble and isInfinity didn't reveal any spec documents or unit tests, hence there are no additions in this regard.

Merging into 2.12.x to address both .12 and .13.

This is my first contribution. I have signed the Scala CLA. If there are any worries, let me know.

@scala-jenkins scala-jenkins added this to the 2.12.9 milestone May 16, 2019
@SethTisue
Copy link
Member
8000

I'm afraid it's much too late to add this for 2.12.x, as per https://docs.scala-lang.org/overviews/core/binary-compatibility-of-scala-releases.html

it's also too late to add it for 2.13.x, unless we do a 2.13.0-RC3

@SethTisue SethTisue added the welcome hello new contributor! label May 16, 2019
@otto-dev
Copy link
Author
otto-dev commented May 16, 2019

I see, thanks.

it's also too late to add it for 2.13.x

Do you mean too late for 2.13.0, or 2.13 altogether? Any point in rebasing this to the 2.13.x branch for either 2.13.1 or 2.13.0-RC3?

(edit: CI also picked up on this)

@SethTisue
Copy link
Member

Do you mean too late for 2.13.0, or 2.13 altogether?

too late for 2.13 altogether, since once 2.13.0 is out, binary compatibility is frozen for the duration of the 2.13.x series

we'll have a 2.14.x branch before much longer

@otto-dev
Copy link
Author

Thanks for the reply, makes perfect sense. Closing this for now...

@otto-dev otto-dev closed this May 17, 2019
@otto-dev otto-dev deleted the fix/doubleIsFinite branch May 17, 2019 12:12
@SethTisue SethTisue removed this from the 2.12.9 milestone May 17, 2019
@som-snytt
Copy link
Contributor

It would be interesting to have a project, possibly curated by the company formerly known as typesafe, as a grab bag for enrichments like this one. Depending on the artifact is explicit, so it would be a way to sidestep compatibility issues, but still benefit from API which progress in the natural way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
welcome hello new contributor!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0