8000 Whitelist the remaining changes since 2.12.0 that break all builds by szeiger · Pull Request #5549 · scala/scala · GitHub
[go: up one dir, main page]
Skip to content

Whitelist the remaining changes since 2.12.0 that break all builds #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Whitelist the remaining changes since 2.12.0 that break all builds #5549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Whitelist the remaining changes since 2.12.0 that break all builds 
The changes were made in #5481,
subsequently breaking binary compatibility checks after
#5532 was merged, too. The affected
methods are part of an internal implementation class. Whitelisting
should be safe.
  • Loading branch information
@szeiger
szeiger committed Nov 21, 2016
commit 3107532f459d4a66ecd302f0b39b14bd7cf2d248
5 changes: 4 additions & 1 deletion bincompat-backward.whitelist.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ filter {
{
matchName="scala.reflect.runtime.SymbolLoaders#TopClassCompleter.this"
problemName=IncompatibleMethTypeProblem
},
{
matchName="scala.sys.process.ProcessImpl#CompoundProcess.getExitValue"
problemName=DirectMissingMethodProblem
}

]
}
8 changes: 8 additions & 0 deletions bincompat-forward.whitelist.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ filter {
{
matchName="scala.reflect.runtime.SymbolLoaders#TopClassCompleter.this"
problemName=IncompatibleMethTypeProblem
},
{
matchName="scala.sys.process.ProcessImpl#CompoundProcess.futureValue"
problemName=DirectMissingMethodProblem
},
{
matchName="scala.sys.process.ProcessImpl#CompoundProcess.futureThread"
problemName=DirectMissingMethodProblem
}
]
}
0