Reinstate MiMa and address problems #5532
Conversation
- Revert a typo fix to a non-private method
- Whitelist changes to internals of runtime reflection that
are not part of the API and should only be referenced from
within scala-reflect.jar itself.
This reverts commit 656162b. Adding new APIs is not possible until a major release.
MiMa has been off-duty because of a bug in handling the default value of the new paramter `--direction`. This commit explicitly provides this parameter to get things working again post haste. Fixes scala/scala-dev#264
|
The ant and sbt builds on the 2.11.x branch use a version of MiMa that predates the regression. |
|
D'Oh! |
|
/synch |
|
Could you expand on why the scala.reflect.runtime changes are safe? Is there no way these methods could be called from user code? I guess we could classify this under the experimental API exemption, but would still be good to rubber duck debug this and see if there's a worse worst case scenario. |
|
(I'm on phone, didn't look at their scala source visibility) |
|
@adriaanm The only public API in The rest should really be in The particular methods excluded here are nested within |
The changes were made in scala#5481, subsequently breaking binary compatibility checks after scala#5532 was merged, too. The affected methods are part of an internal implementation class. Whitelisting should be safe.
No description provided.