feat(): add rxScheduleTask function #1633
Conversation
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
| ### Default usage | ||
|
|
||
| ```typescript | ||
| import { rxScheduleTask } from '@rx-angular/cdk/render-strategies'; |
There was a problem hiding this comment.
| import { rxScheduleTask } from '@rx-angular/cdk/render-strategies'; | |
| import { rxScheduleTask } from '@rx-angular/cdk/render-strategies'; |
I don't like it that we export it from render-strategies. Because it doesn't do anything with rendering.
There was a problem hiding this comment.
Can you think about better place? We had this discussion in old PR and decided that this is the best option we currently have. We can say the same about RxStrategyProvider, aren't we? This is a service for scheduling any type of work, but it's still in the render-strategies. Same reasoning goes to rxScheduleTask.
You can make it "related" to rendering by doing rxScheduleTask(() => this.cdRef.detectChanges()) ¯_(ツ)_/¯.
There was a problem hiding this comment.
we can introduce a new sub-package for scheduling?
There was a problem hiding this comment.
I would do a rethink before and maybe see what other code we want to move
There was a problem hiding this comment.
Whatever we decide, please let's not have it frozen for another 1.5 years :D
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Julian Jandl <julian@jandl.wien>
Introduces
rxScheduleTaskfunction to schedule tasks with our scheduler.This is a minimal building block for our concurrent scheduling functionality.
Includes feedback from old PR #1344.