feat(cdk): add rxScheduleTask function #1344
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4aa53ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
hi @Karnaukhov-kh very nice PR, i like the idea a lot! Left some thoughts in the comments
| export const rxScheduleTask = ( | ||
| work: (...args: any[]) => void, | ||
| strategy: keyof StrategiesPriorityRecord = 'normal', | ||
| options?: { | ||
| delay?: number; | ||
| ngZone?: NgZone; | ||
| } | ||
| ) => { | ||
| const task = scheduleCallback( | ||
| strategiesPrio[strategy], | ||
| () => work(), | ||
| options | ||
| ); | ||
| return () => { | ||
| cancelCallback(task); | ||
| }; | ||
| }; |
There 8000 was a problem hiding this comment.
why don't we provide an observable version of this standalone function as well?
There was a problem hiding this comment.
Isn't scheduleOnQueue already an operator that uses it, but with coalescing?
| */ | ||
| export const rxScheduleTask = ( | ||
| work: (...args: any[]) => void, | ||
| strategy: keyof StrategiesPriorityRecord = 'normal', |
There was a problem hiding this comment.
How would a user use the function with a custom strategy? the typing wouldn't allow it currently. Or am I missing something?
There was a problem hiding this comment.
I guess we should not use custom strategy here, because only thing we need from strategy is priority. And scheduler not working with custom priority levels.
That's why we need this ⬇️, to provide users familiar API instead of PriorityLevel enum.
const strategiesPrio: StrategiesPriorityRecord = {
immediate: PriorityLevel.ImmediatePriority,
userBlocking: PriorityLevel.UserBlockingPriority,
normal: PriorityLevel.NormalPriority,
low: PriorityLevel.LowPriority,
idle: PriorityLevel.IdlePriority,
};
|
Thank you for feedback @hoebbelsB @edbzn, I'll answer and apply changes soon :). |
Co-authored-by: Edouard Bozon <bozonedouard@gmail.com>
| export const rxScheduleTask = ( | ||
| work: (...args: any[]) => void, | ||
| 8000 options?: { | ||
| strategy?: keyof StrategiesPriorityRecord; | ||
| delay?: number; | ||
| ngZone?: NgZone; | ||
| } | ||
| ) => { | ||
| const task = scheduleCallback( | ||
| strategiesPrio[options?.strategy || defaultStrategy], | ||
| () => work(), | ||
| { | ||
| delay: options?.delay, | ||
| ngZone: options?.ngZone, | ||
| } | ||
| ); | ||
| return () => { | ||
| cancelCallback(task); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
What about the following syntax to initialize options?
| export const rxScheduleTask = ( | |
| work: (...args: any[]) => void, | |
| options?: { | |
| strategy?: keyof StrategiesPriorityRecord; | |
| delay?: number; | |
| ngZone?: NgZone; | |
| } | |
| ) => { | |
| const task = scheduleCallback( | |
| strategiesPrio[options?.strategy || defaultStrategy], | |
| () => work(), | |
| { | |
| delay: options?.delay, | |
| ngZone: options?.ngZone, | |
| } | |
| ); | |
| return () => { | |
| cancelCallback(task); | |
| }; | |
| }; | |
| export const rxScheduleTask = ( | |
| work: (...args: any[]) => void, | |
| { | |
| strategy = defaultStrategy, | |
| delay, | |
| ngZone, | |
| }: { | |
| strategy?: keyof StrategiesPriorityRecord; | |
| delay?: number; | |
| ngZone?: NgZone; | |
| } = {} | |
| ) => { | |
| const task = scheduleCallback(strategiesPrio[strategy], () => work(), { | |
| delay, | |
| ngZone, | |
| }); | |
| return () => { | |
| cancelCallback(task); | |
| }; | |
| }; |
|
Closing in favor of #1633 |
Introduces
rxScheduleTaskfunction to schedule tasks with our scheduler.