10000 Another upstream merge + build system fix by alexcrichton · Pull Request #9 · rust-lang/llvm-project · GitHub
[go: up one dir, main page]

Skip to content

Another upstream merge + build system fix #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 26, 2019
Merged
Prev Previous commit
Delete version check for clang-cl
We have a 19.0 version but it's checking for 19.0.2xxx, so presumably
it's just a bug in the compiler check and we should be running alright.
For now just assume that, delete this, and see if this is fixed by the
next LLVM release.
  • Loading branch information
alexcrichton committed Feb 26, 2019
commit f6605a6dcc678e8742e280c92a40a000202fd4d7
3 changes: 0 additions & 3 deletions llvm/cmake/modules/CheckCompilerVersion.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ check_compiler_version("MSVC" "Visual Studio" ${MSVC_MIN} ${MSVC_SOFT_ERROR})

if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
if (CMAKE_CXX_SIMULATE_ID MATCHES "MSVC")
if (CMAKE_CXX_SIMULATE_VERSION VERSION_LESS MSVC_MIN)
message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_SIMULATE_VERSION}.")
endif()
set(CLANG_CL 1)
elseif(NOT LLVM_ENABLE_LIBCXX)
# Test that we aren't using too old of a version of libstdc++.
Expand Down
0