8000 Fix CVE-2018-1000544 and disable symlinks to avoid other security issues by jdleesmiller · Pull Request #376 · rubyzip/rubyzip · GitHub
[go: up one dir, main page]
Skip to content

Fix CVE-2018-1000544 and disable symlinks to avoid other security issues #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 31, 2018
Merged

Fix CVE-2018-1000544 and disable symlinks to avoid other security issues #376

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e0d231
Fix CVE-2018-1000544 absolute path traversal
bdewater Jul 1, 2018
8e78311
Fix CVE-2018-1000544 symlink path traversal
bdewater Jul 1, 2018
cf71583
Move jruby to allow failures matrix till crc uint 32 issues are resolved
vipulnsward Aug 26, 2018
0586329
Trigger CI again
bdewater Aug 26, 2018
9c468f3
Add jwilk's path traversal tests
jdleesmiller Aug 26, 2018 8000
ffebfa3
Consolidate path traversal tests
jdleesmiller Aug 26, 2018
3dd165b
Disable symlinks and check for path traversal
jdleesmiller Aug 26, 2018
8a1de58
Expand from root rather than current working directory
jdleesmiller Aug 26, 2018
ffb374c
Bump version to 2.0.0
jdleesmiller Aug 27, 2018
cf35774
Bump version to 1.3.0
jdleesmiller Aug 27, 2018
fd81bd5
Bump version to 1.2.2
jdleesmiller Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump version to 2.0.0
  • Loading branch information
@jdleesmiller
jdleesmiller committed Aug 27, 2018
commit ffb374c6b1757f6b5eb93e68b8b37ebc7df3f310
2 changes: 1 addition & 1 deletion lib/zip/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Zip
VERSION = '1.2.1'
VERSION = '2.0.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdleesmiller can you please revert this? Or at least release a patch version of 1.2 as well?

The thing is all the libraries we have in Gemfile.lock either explicitly declare < 2.0.0 or ~> 1.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That is a good point about version constraints.

My rationale was that dropping support for symlinks completely is a breaking change, and I'd be unhappy if semver minor or patch release broke my app.

If you have ~> 1.2, I guess 1.3.0 should do it. It's not very semantic, but it does seem like the pragmatic solution. Happy to try it out.

end
Binary file modified test/data/rubycode.zip
View file
Open in desktop
Binary file not shown.
0