8000 Fix CVE-2018-1000544 and disable symlinks to avoid other security issues by jdleesmiller · Pull Request #376 · rubyzip/rubyzip · GitHub
[go: up one dir, main page]
Skip to content

Fix CVE-2018-1000544 and disable symlinks to avoid other security issues #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 31, 2018
Merged

Fix CVE-2018-1000544 and disable symlinks to avoid other security issues #376

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e0d231
Fix CVE-2018-1000544 absolute path traversal
bdewater Jul 1, 2018
8e78311
Fix CVE-2018-1000544 symlink path traversal
bdewater Jul 1, 2018
cf71583
Move jruby to allow failures matrix till crc uint 32 issues are resolved
vipulnsward Aug 26, 2018
0586329
Trigger CI again
bdewater Aug 26, 2018
9c468f3
Add jwilk's path traversal tests
jdleesmiller Aug 26, 2018
ffebfa3
Consolidate path traversal tests
jdleesmiller Aug 26, 2018
3dd165b
Disable symlinks and check for path traversal
jdleesmiller Aug 26, 2018
8a1de58
Expand from root rather than current working directory
jdleesmiller Aug 26, 2018
ffb374c
Bump version to 2.0.0
jdleesmiller Aug 27, 2018
cf35774
Bump version to 1.3.0
jdleesmiller Aug 27, 2018
fd81bd5
Bump version to 1.2.2
jdleesmiller Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expand from root rather than current working directory
  • Loading branch information
@jdleesmiller
jdleesmiller committed Aug 26, 2018
commit 8a1de5828658bfa0350c2325f311bd6acad261a2
5 changes: 3 additions & 2 deletions lib/zip/entry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,9 @@ def name_is_directory? #:nodoc:all
def name_safe?
cleanpath = Pathname.new(@name).cleanpath
return false unless cleanpath.relative?
naive_expanded_path = ::File.join(Dir.pwd, cleanpath.to_s)
cleanpath.expand_path.to_s == naive_expanded_path
root = ::File::SEPARATOR
naive_expanded_path = ::File.join(root, cleanpath.to_s)
cleanpath.expand_path(root).to_s == naive_expanded_path
end

def local_entry_offset #:nodoc:all
Expand Down
0