Add configs of rubocop gem and fix some rubocop warnings #226
Conversation
|
@ShockwaveNN If you have a time then ok. But rubocop is not enough. You can look on reek and cane. |
| @@ -0,0 +1,2 @@ | |||
| inherit_from: | |||
| - .rubocop_todo.yml | |||
There was a problem hiding this comment.
Please rename file to .rubocop_rubyzip.yml
There was a problem hiding this comment.
Are you sure about it?
Without renaming I can just run rubocop command from root of project and it will use this config file, but if i rename - I should run rubocop -c .rubocop_rubyzip.yml
There was a problem hiding this comment.
Why? you renaming file and renaming entry in .rubocop.yml
There was a problem hiding this comment.
Oh, I get it. I thought you mention .rubocop.yml file, but you mention .rubocop_todo.yml file
|
I fixed some trivial problems, I stop now, but try to continue tomorrow |
1 similar comment
|
I think I fixed almost all trivial cases, so I think it may be merged with master, because after that point fixes will be more dramatical, and may be lost in existing changes. Existing changes is small, but there is too much number of them. Also future fixes volumes will not be so high, as now |
|
Can you rebase with latest master? |
|
@simonoff Yes, of course I can rebase. I try to do it tomorrow |
|
@simonoff Done rebasing, also update rubocop and fix some more problems |
Add configs of rubocop gem and fix some rubocop warnings
I run rubocop (https://github.com/bbatsov/rubocop) gem on this project and fix some of problem to try it out.
If maintainers of this project think this is good idea - I can continue to fix code style warnings and creating pull requests for it