Add Ability to write Zip File to Buffer instead of File Stream. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zf| ... } => buffer
|
Cool idea |
|
Let me know if you need any further test coverage, functionality, etc before pulling it into the main repo.. |
|
I'm keen to get this functionality into the rubyzip gem as currently I have a extension file to add this functionality within my application.. Can you let me know if there is anything I can do to make this happen. |
|
Sorry about the delay, I'm just about back on deck. Still have a few other things to sort out before the next release, but that won't be far off |
simonoff
added a commit
that referenced
this pull request
Jun 3, 2013
Rubyzip interface was changed!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above functionality is convenient for Rails applications where you do not want to deal with unique filename for saving the data to the filesystem.
David