[Feature #20187] Skip examples for bundled gems at Ruby 3.4 #9960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.bundle` directory is for rspec examples and `test-bundled-gems`. ruby#6130 is focus to build bundled gems, not testing. It's accidentally side effect. Also see ruby@5bf75c2
…"' spec/ruby/library/bigdecimal/**/*_spec.rb
…"' spec/ruby/library/csv/**/*.rb
…"' spec/ruby/library/syslog/**/*.rb
…"' spec/ruby/library/base64/**/*_spec.rb
…"' spec/ruby/library/observer/**/*.rb
…"' spec/ruby/library/getoptlong/**/*.rb
…"' spec/ruby/library/abbrev/**/*.rb
spec/mspec/tool/wrap_with_guard.rb 'ruby_version_is ""..."3.4"' spec/ruby/core/rational/coerce_spec.rb spec/mspec/tool/wrap_with_guard.rb 'ruby_version_is ""..."3.4"' spec/ruby/library/bigmath/log_spec.rb spec/mspec/tool/wrap_with_guard.rb 'ruby_version_is ""..."3.4"' spec/ruby/core/integer/coerce_spec.rb and spec/ruby/core/time/at_spec.rb
eregon
reviewed
Feb 14, 2024
| 1.coerce(2).map { |i| i.class }.should == [Integer, Integer] | ||
| end | ||
| end | ||
| ruby_version_is ""..."3.4" do |
There was a problem hiding this comment.
This disables all Integer#coerce specs, it's not OK.
Same for Rational#coerce specs below.
|
I discussed this with @nurse. We will separate
I will make |
|
That sounds good. |
|
I would still like to understand what is a concrete problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added version guard to
ruby/specfor Ruby 3.4 again.ruby/spec#1137 reverts all of commits and enable to run them again.
In background, maintaining bundled gems is out of scope ruby repository. We shouldn't keep their test code because they are not our responsibility. We only test them with
test-bundled-gemsfor ruby Interpreter keep their support.#6130 makes to load bundled gems on
test-spec. But it's accidentally changes fortest-spec.Also see 5bf75c2