Make the built ruby runnable with bundled gems #6130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since extension libraries can not be built in the source directory, rubygems warns gems have extension libraries as the extensions are not built. To order to suppress this warnings, extract such gemspec files under each gem directories instead of the common `specifications` directory.
The default gems have not been installed yet in the build directory, bundled gems depending on them can not work. As those dependencies should be usable there even without rubygems, make temporary gemspec files without the dependencies, and use them in the build directory.
Gemspec files having extension libraries are placed under each gem directories now.
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Feb 14, 2024
`.bundle` directory is for rspec examples and `test-bundled-gems`. ruby#6130 is focus to build bundled gems, not testing. It's accidentally side effect. Also see ruby@5bf75c2
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Feb 15, 2024
`.bundle` directory is for rspec examples and `test-bundled-gems`. ruby#6130 is focus to build bundled gems, not testing. It's accidentally side effect. Also see ruby@5bf75c2
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Feb 15, 2024
`.bundle` directory is for rspec examples and `test-bundled-gems`. ruby#6130 is focus to build bundled gems, not testing. It's accidentally side effect. Also see ruby@5bf75c2
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Feb 15, 2024
`.bundle` directory is for rspec examples and `test-bundled-gems`. ruby#6130 is focus to build bundled gems, not testing. It's accidentally side effect. Also see ruby@5bf75c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to be able to run the bundled gem tests using the built ruby as is.
This is an intermediate step toward that goal.