Support iterable type for all methods working with multiple keys
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for the
iterabletype for all methods working with multiple keys. This is done to bring theCacheInterfacemore in line with PSR-16 which also happens to support theiterabletype (as originally suggested in #32).setMultiple()method now acceptsiterable<string,mixed> $valuesinstead ofarray<string,mixed>. For consumers, passing anarraycontinues to work like usual, but implementations of theCacheInterfacemay have to be adjusted to accept theiterabletype.deleteMultiple()method now acceptsiterable<string> $keysinstead ofstring[]. For consumers, passing anarraycontinues to work like usual, but implementations of theCacheInterfacemay have to be adjusted to accept theiterabletype.getMultiple()method now acceptsiterable<string> $keysinstead ofstring[]and returns aniterable<string,mixed>instead ofarray<string,mixed>. For consumers, passing anarraycontinues to work as usual, but implementations ofCacheInterfacemay have to be adjusted to accept theiterabletype.Builds on top of #58, #60, #61 and #32
Refs reactphp/promise#225, #30 and others