Add native types to public API #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
approved these changes
May 16, 2024
This was referenced May 16, 2024
WyriHaximus
reviewed
May 17, 2024
WyriHaximus
approved these changes
May 19, 2024
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 14, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
9F4C
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 14, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds native types to the public API as discussed in #56.
As discussed in #59, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types.
Once merged, we should apply similar changes to all our upcoming v3 components.
Builds on top of #58