[added] createSelectedEvent for consistent onSelect handling
#787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't had time to read through the related PR, but this implementation seems to be a lot more general than just handling "select" events. |
|
This doesn't go and update any of the select events, it's just the event that would get passed in as described in #419 (comment). I have already been using it in the dropdown-revisited branch and felt that @roadmanfong would benefit from it in #786 Example usage from dropdown-revisited: |
|
@taion Did I answer your question completely or did I miss something? |
|
Yes - question answered. Thanks. |
|
👍 LGTM |
mtscout6
added a commit
that referenced
this pull request
Jun 5, 2015
[added] `createSelectedEvent` for consistent onSelect handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #419
This is the event that I have started using on the dropdown-revisited branch. Thought I'd pull the event from that branch in hopes that it may help with the events in #786