8000 Change calls to e.preventDefault() to allow onClick and onSelect calls to override · Issue #419 · react-bootstrap/react-bootstrap · GitHub
[go: up one dir, main page]

Skip to content
Change calls to e.preventDefault() to allow onClick and onSelect calls to override #419
Closed
@mtscout6

Description

@mtscout6

There has been a number of concerns raised recently regarding e.preventDefault(); getting applied without regard for what a developer would actually want to occur. This occurs regularly when attempting to do client side routing. This search will highlight a few such cases.

I'd like to move to a more consistent model similar to this. Where the user's onClick or onSelect handler can return true or false to explicitly control it. This is also similar to how jQuery has handled things.

List of components to address: (Not conclusive yet)

  • Dropdown
  • Panel (Collapse)
  • PanelGroup
  • Button
  • Nav
  • Navbar
  • NavItem
  • Carousel
  • CollapsableNav
  • PageItem
  • Pager
  • Split Button
  • TabbedArea

refs about documenting it:
#432
#320

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0