8000 Removed torch.cholesky and added torch.linalg.cholesky by IvanYashchuk · Pull Request #3274 · pytorch/xla · GitHub
[go: up one dir, main page]
Skip to content

Removed torch.cholesky and added torch.linalg.cholesky #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Removed torch.cholesky and added torch.linalg.cholesky #3274

wants to merge 4 commits into from

Conversation

IvanYashchuk
Copy link
Contributor
@IvanYashchuk IvanYashchuk commented Jan 3, 2022 •
edited
Loading

torch.cholesky was deprecated in the 1.9 release and will be removed in the next 1.11 release. This PR removes cholesky and replaces it with the linalg_cholesky.

pytorch/pytorch#70979 that removes deprecated torch.cholesky from PyTorch is currently blocked by pytorch/xla.

This was referenced Jan 3, 2022
Closed
Open
@IvanYashchuk IvanYashchuk mentioned this pull request Jan 14, 2022
Closed
@IvanYashchuk
Copy link
Contributor Author

CI checks pass. @JackCaoG, could you please review this PR and #3273, #3272?

@JackCaoG
Copy link
Collaborator

@IvanYashchuk Will do today

@JackCaoG JackCaoG self-requested a review January 28, 2022 19:18
JackCaoG
JackCaoG approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator
@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me a ping before you merge the pytorch pr

@IvanYashchuk IvanYashchuk force-pushed the remove-deprecated-cholesky branch from bf4b7b9 to f01f21e Compare April 5, 2023 11:58
@IvanYashchuk
Removed torch.cholesky and added torch.linalg.cholesky
16d12d4 
clang-format-7

Try branch with linalg_qr symbol

Revert "Try branch with linalg_qr symbol"

This reverts commit db3e9a7.

Update tensor_methods

Restore formatting

use tensor_methods::linalg_cholesky

Remove cholesky
@IvanYashchuk IvanYashchuk force-pushed the remove-deprecated-cholesky branch from f01f21e to 16d12d4 Compare April 5, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees
No one assigned
Labels
REMOVE_TORCH_PIN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanYashchuk @JackCaoG
0