-
Notifications
You must be signed in to change notification settings - Fork 24.2k
Remove deprecated torch.cholesky #70979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow For more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit df7ff65 (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
test/test_linalg.py
Outdated
@@ -17,7 +17,7 @@ | |||
from torch.testing._internal.common_utils import \ | |||
(TestCase, run_tests, TEST_SCIPY, IS_MACOS, IS_WINDOWS, slowTest, | |||
TEST_WITH_ASAN, TEST_WITH_ROCM, IS_FBCODE, IS_REMOTE_GPU, | |||
iter_indices, gradcheck, gradgradcheck, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiiiiceee!
@pytorchbot ciflow rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to add this PR updates XLA submodule
otherwise merge bot would refuse to merge
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
@IvanYashchuk @lezcano A question. |
In my tests TorchFix PR to do this replacement: pytorch/test-infra#4336 |
Intially, we didn't want to have an That's the historical context of that weird flag :) |
I see, I'll use |
@lezcano |
|
ah, I see, yeah, I meant |
The time has come to remove deprecated linear algebra related functions. This PR removes torch.cholesky.
Fixes to torch/xla need to be merged before this PR:
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @lezcano @mcarilli @ptrblck @leslie-fang-intel @jgong5 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @soumith @yanboliang @anijain2305 @desertfire @IvanYashchuk