10000 Remove deprecated torch.cholesky by IvanYashchuk · Pull Request #70979 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Remove deprecated torch.cholesky #70979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

IvanYashchuk
Copy link
Collaborator
@IvanYashchuk IvanYashchuk commented Jan 7, 2022

@IvanYashchuk IvanYashchuk added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: deprecation labels Jan 7, 2022
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Jan 7, 2022
@pytorch-probot
Copy link
pytorch-probot bot commented Jan 7, 2022
CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/IvanYashchuk/pytorch/blob/1d6b073582e86a1ec62fecd2f0e7cc602c6136af/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/cuda,ciflow/all

Workflows Labels (bold enabled) Status
Triggered Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk ✅ triggered
docker-builds ciflow/all, ciflow/trunk ✅ triggered
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
ios-12-5-1-x86-64-full-jit ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk ✅ triggered
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk ✅ triggered
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk ✅ triggered
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk ✅ triggered
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk ✅ triggered
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk ✅ triggered
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk ✅ triggered
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck ✅ triggered
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled ✅ triggered
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win ✅ triggered
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
Skipped Workflows

You can add a comment to the PR and tag @pytorchbot with the following commands:
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jan 7, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit df7ff65 (more details on the Dr. CI page):


  • 4/6 failures introduced in this PR
  • 2/6 broken upstream at merge base 89d6f3e on Mar 11 from 4:52am to 5:05am

🕵️ 4 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build win-vs2019-cuda11.3-py3 / build (1/4)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-11T15:11:13.5800630Z C:\actions-runner\...zed_test.cpp(34): error C2100: illegal indirection
2022-03-11T15:11:13.5789806Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\initializer_list(57): note: see declaration of 'std::begin'
2022-03-11T15:11:13.5790843Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2672: 'end': no matching overloaded function found
2022-03-11T15:11:13.5791971Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2893: Failed to specialize function template 'unknown-type std::end(_Container &)'
2022-03-11T15:11:13.5793152Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\xutility(2179): note: see declaration of 'std::end'
2022-03-11T15:11:13.5794117Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): note: With the following template arguments:
2022-03-11T15:11:13.5795046Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): note: '_Container=int'
2022-03-11T15:11:13.5796234Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2784: 'const _Elem *std::end(std::initializer_list<_Elem>) noexcept': could not deduce template argument for 'std::initializer_list<_Elem>' from 'int'
2022-03-11T15:11:13.5797479Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\initializer_list(63): note: see declaration of 'std::end'
2022-03-11T15:11:13.5798565Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C3536: '<begin>$L1': cannot be used before it is initialized
2022-03-11T15:11:13.5799618Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C3536: '<end>$L1': cannot be used before it is initialized
2022-03-11T15:11:13.5800630Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2100: illegal indirection
2022-03-11T15:11:13.5801370Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-11T15:11:13.5801958Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-11T15:11:13.5802367Z 
2022-03-11T15:11:13.9898788Z [4432/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_Device_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_Device_test.dir\core\Device_test.cpp.obj  /out:bin\c10_Device_test.exe /implib:lib\c10_Device_test.lib /pdb:bin\c10_Device_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:11:13.9909792Z [4433/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_DispatchKeySet_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_DispatchKeySet_test.dir\core\DispatchKeySet_test.cpp.obj  /out:bin\c10_DispatchKeySet_test.exe /implib:lib\c10_DispatchKeySet_test.lib /pdb:bin\c10_DispatchKeySet_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:11:14.0050233Z [4434/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_StreamGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_StreamGuard_test.dir\core\StreamGuard_test.cpp.obj  /out:bin\c10_StreamGuard_test.exe /implib:lib\c10_StreamGuard_test.lib /pdb:bin\c10_StreamGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:11:14.0064417Z [4435/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_DeviceGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_DeviceGuard_test.dir\core\DeviceGuard_test.cpp.obj  /out:bin\c10_DeviceGuard_test.exe /implib:lib\c10_DeviceGuard_test.lib /pdb:bin\c10_DeviceGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:11:14.0256001Z [4436/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_InlineStreamGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_InlineStreamGuard_test.dir\core\impl\InlineStreamGuard_test.cpp.obj  /out:bin\c10_InlineStreamGuard_test.exe /implib:lib\c10_InlineStreamGuard_test.lib /pdb:bin\c10_InlineStreamGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:11:14.0270046Z [4437/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_InlineDeviceGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_InlineDeviceGuard_test.dir\core\impl\InlineDeviceGuard_test.cpp.obj  /out:bin\c10_InlineDeviceGuard_test.exe /implib:lib\c10_InlineDeviceGuard_test.lib /pdb:bin\c10_InlineDeviceGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:11:14.4469768Z [4438/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_CompileTimeFunctionPointer_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_CompileTimeFunctionPointer_test.dir\core\CompileTimeFunctionPointer_test.cpp.obj  /out:bin\c10_CompileTimeFunctionPointer_test.exe /implib:lib\c10_CompileTimeFunctionPointer_test.lib /pdb:bin\c10_CompileTimeFunctionPointer_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."

See GitHub Actions build periodic-win-vs2019-cuda11.5-py3 / build (2/4)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-11T15:10:00.0635381Z C:\actions-runner\...zed_test.cpp(34): error C2100: illegal indirection
2022-03-11T15:10:00.0624889Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\initializer_list(57): note: see declaration of 'std::begin'
2022-03-11T15:10:00.0625905Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2672: 'end': no matching overloaded function found
2022-03-11T15:10:00.0627010Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2893: Failed to specialize function template 'unknown-type std::end(_Container &)'
2022-03-11T15:10:00.0628094Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\xutility(2179): note: see declaration of 'std::end'
2022-03-11T15:10:00.0629059Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): note: With the following template arguments:
2022-03-11T15:10:00.0629951Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): note: '_Container=int'
2022-03-11T15:10:00.0631163Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2784: 'const _Elem *std::end(std::initializer_list<_Elem>) noexcept': could not deduce template argument for 'std::initializer_list<_Elem>' from 'int'
2022-03-11T15:10:00.0632399Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\initializer_list(63): note: see declaration of 'std::end'
2022-03-11T15:10:00.0633403Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C3536: '<begin>$L1': cannot be used before it is initialized
2022-03-11T15:10:00.0634429Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C3536: '<end>$L1': cannot be used before it is initialized
2022-03-11T15:10:00.0635381Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2100: illegal indirection
2022-03-11T15:10:00.0636092Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-11T15:10:00.0636670Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-11T15:10:00.0637015Z 
2022-03-11T15:10:00.0640144Z [4430/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_CompileTimeFunctionPointer_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_CompileTimeFunctionPointer_test.dir\core\CompileTimeFunctionPointer_test.cpp.obj  /out:bin\c10_CompileTimeFunctionPointer_test.exe /implib:lib\c10_CompileTimeFunctionPointer_test.lib /pdb:bin\c10_CompileTimeFunctionPointer_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:10:00.2711252Z [4431/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_InlineDeviceGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_InlineDeviceGuard_test.dir\core\impl\InlineDeviceGuard_test.cpp.obj  /out:bin\c10_InlineDeviceGuard_test.exe /implib:lib\c10_InlineDeviceGuard_test.lib /pdb:bin\c10_InlineDeviceGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:10:00.3187524Z [4432/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_Device_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_Device_test.dir\core\Device_test.cpp.obj  /out:bin\c10_Device_test.exe /implib:lib\c10_Device_test.lib /pdb:bin\c10_Device_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:10:00.3201123Z [4433/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_DeviceGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_DeviceGuard_test.dir\core\DeviceGuard_test.cpp.obj  /out:bin\c10_DeviceGuard_test.exe /implib:lib\c10_DeviceGuard_test.lib /pdb:bin\c10_DeviceGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:10:00.3857481Z [4434/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_StreamGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_StreamGuard_test.dir\core\StreamGuard_test.cpp.obj  /out:bin\c10_StreamGuard_test.exe /implib:lib\c10_StreamGuard_test.lib /pdb:bin\c10_StreamGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:10:00.4192760Z [4435/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_DispatchKeySet_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_DispatchKeySet_test.dir\core\DispatchKeySet_test.cpp.obj  /out:bin\c10_DispatchKeySet_test.exe /implib:lib\c10_DispatchKeySet_test.lib /p
8000
db:bin\c10_DispatchKeySet_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:10:00.4757116Z [4436/6220] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_InlineStreamGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_InlineStreamGuard_test.dir\core\impl\InlineStreamGuard_test.cpp.obj  /out:bin\c10_InlineStreamGuard_test.exe /implib:lib\c10_InlineStreamGuard_test.lib /pdb:bin\c10_InlineStreamGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."

See GitHub Actions build win-vs2019-cpu-py3 / build (3/4)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-11T15:09:36.0580952Z C:\actions-runner\...zed_test.cpp(34): error C2100: illegal indirection
2022-03-11T15:09:36.0570350Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\initializer_list(57): note: see declaration of 'std::begin'
2022-03-11T15:09:36.0571356Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2672: 'end': no matching overloaded function found
2022-03-11T15:09:36.0572498Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2893: Failed to specialize function template 'unknown-type std::end(_Container &)'
2022-03-11T15:09:36.0573590Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\xutility(2179): note: see declaration of 'std::end'
2022-03-11T15:09:36.0574550Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): note: With the following template arguments:
2022-03-11T15:09:36.0575473Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): note: '_Container=int'
2022-03-11T15:09:36.0576733Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2784: 'const _Elem *std::end(std::initializer_list<_Elem>) noexcept': could not deduce template argument for 'std::initializer_list<_Elem>' from 'int'
2022-03-11T15:09:36.0577957Z C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.28.29333\include\initializer_list(63): note: see declaration of 'std::end'
2022-03-11T15:09:36.0578978Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C3536: '<begin>$L1': cannot be used before it is initialized
2022-03-11T15:09:36.0580007Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C3536: '<end>$L1': cannot be used before it is initialized
2022-03-11T15:09:36.0580952Z C:\actions-runner\_work\pytorch\pytorch\c10\test\util\Synchronized_test.cpp(34): error C2100: illegal indirection
2022-03-11T15:09:36.0581672Z Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64
2022-03-11T15:09:36.0582249Z Copyright (C) Microsoft Corporation.  All rights reserved.
2022-03-11T15:09:36.0582582Z 
2022-03-11T15:09:36.8159316Z [4429/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_InlineStreamGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_InlineStreamGuard_test.dir\core\impl\InlineStreamGuard_test.cpp.obj  /out:bin\c10_InlineStreamGuard_test.exe /implib:lib\c10_InlineStreamGuard_test.lib /pdb:bin\c10_InlineStreamGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:09:36.8171690Z [4430/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_InlineDeviceGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_InlineDeviceGuard_test.dir\core\impl\InlineDeviceGuard_test.cpp.obj  /out:bin\c10_InlineDeviceGuard_test.exe /implib:lib\c10_InlineDeviceGuard_test.lib /pdb:bin\c10_InlineDeviceGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:09:36.8346533Z [4431/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_StreamGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_StreamGuard_test.dir\core\StreamGuard_test.cpp.obj  /out:bin\c10_StreamGuard_test.exe /implib:lib\c10_StreamGuard_test.lib /pdb:bin\c10_StreamGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:09:36.8368699Z [4432/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_DispatchKeySet_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_DispatchKeySet_test.dir\core\DispatchKeySet_test.cpp.obj  /out:bin\c10_DispatchKeySet_test.exe /implib:lib\c10_DispatchKeySet_test.lib /pdb:bin\c10_DispatchKeySet_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:09:36.8537069Z [4433/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_DeviceGuard_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_DeviceGuard_test.dir\core\DeviceGuard_test.cpp.obj  /out:bin\c10_DeviceGuard_test.exe /implib:lib\c10_DeviceGuard_test.lib /pdb:bin\c10_DeviceGuard_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:09:36.8753975Z [4434/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_Device_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_Device_test.dir\core\Device_test.cpp.obj  /out:bin\c10_Device_test.exe /implib:lib\c10_Device_test.lib /pdb:bin\c10_Device_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
2022-03-11T15:09:37.0869118Z [4435/5803] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=c10\test\CMakeFiles\c10_SizesAndStrides_test.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  c10\test\CMakeFiles\c10_SizesAndStrides_test.dir\core\impl\SizesAndStrides_test.cpp.obj  /out:bin\c10_SizesAndStrides_test.exe /implib:lib\c10_SizesAndStrides_test.lib /pdb:bin\c10_SizesAndStrides_test.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /ignore:4099 /INCREMENTAL:NO /subsystem:console  lib\c10.lib  lib\gmock.lib  lib\gtest.lib  lib\gtest_main.lib  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."

See GitHub Actions build pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (4/4)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-03-11T15:42:37.8159598Z AssertionError: Found an invalid operator name: cholesky
2022-03-11T15:42:37.8155653Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 318, in <module>
2022-03-11T15:42:37.8155904Z     main()
2022-03-11T15:42:37.8156313Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 201, in main
2022-03-11T15:42:37.8156869Z     run(options.source_yaml, options.output_dir, options.dry_run, options.impl_path)
2022-03-11T15:42:37.8157319Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 292, in run
2022-03-11T15:42:37.8157797Z     parsed_backend_yaml = parse_backend_yaml(source_yaml, grouped_native_functions, backend_indices)
2022-03-11T15:42:37.8158194Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 100, in parse_backend_yaml
2022-03-11T15:42:37.8158634Z     supported, backend_key, use_out_as_primary=use_out_as_primary, use_device_guard=use_device_guard)
2022-03-11T15:42:37.8158968Z   File "/var/lib/jenkins/workspace/tools/codegen/gen_backend_stubs.py", line 81, in create_backend_index
2022-03-11T15:42:37.8159302Z     assert op_name in native_functions_map, f"Found an invalid operator name: {op_name}"
2022-03-11T15:42:37.8159598Z AssertionError: Found an invalid operator name: cholesky
2022-03-11T15:42:37.8826447Z Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']
2022-03-11T15:42:38.0304742Z + cleanup
2022-03-11T15:42:38.0305067Z + retcode=1
2022-03-11T15:42:38.0305343Z + set +x
2022-03-11T15:42:38.0345887Z ##[error]Process completed with exit code 1.
2022-03-11T15:42:38.0375676Z ##[group]Run # Ensure the working directory gets chowned back to the current user
2022-03-11T15:42:38.0376020Z �[36;1m# Ensure the working directory gets chowned back to the current user�[0m
2022-03-11T15:42:38.0376322Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m
2022-03-11T15:42:38.0387891Z shell: /usr/bin/bash -e {0}
2022-03-11T15:42:38.0388059Z env:

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@IvanYashchuk IvanYashchuk requested review from mruberry and removed request for ezyang, albanD, soulitzer and nikitaved January 7, 2022 10:50
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 10, 2022
@@ -17,7 +17,7 @@
from torch.testing._internal.common_utils import \
(TestCase, run_tests, TEST_SCIPY, IS_MACOS, IS_WINDOWS, slowTest,
TEST_WITH_ASAN, TEST_WITH_ROCM, IS_FBCODE, IS_REMOTE_GPU,
iter_indices, gradcheck, gradgradcheck,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiiceee!

@IvanYashchuk
Copy link
Collaborator Author

@pytorchbot ciflow rerun

@IvanYashchuk IvanYashchuk requested a review from fegin as a code owner March 7, 2023 11:09
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to add this PR updates XLA submodule otherwise merge bot would refuse to merge

@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

6D40

@kit1980
Copy link
Contributor
kit1980 commented Jul 1, 2023

@IvanYashchuk @lezcano A question.
Why currently the doc recommends updating torch.cholesky(A, upper=True) to torch.linalg.cholesky(A).mH instead of torch.linalg.cholesky(A, upper=True)?

@kit1980
Copy link
Contributor
kit1980 commented Jul 1, 2023

Why currently the doc recommends updating torch.cholesky(A, upper=True) to torch.linalg.cholesky(A).mH instead of torch.linalg.cholesky(A, upper=True)?

In my tests torch.linalg.cholesky(A, upper=True) is the same, so I assume it's correct to replace with it?

TorchFix PR to do this replacement: pytorch/test-infra#4336

@lezcano
Copy link
Collaborator
lezcano commented Jul 1, 2023

Intially, we didn't want to have an upper=True flag in linalg.cholesky, as it's functionally equivalent to cholesky(A).mT. When we first did this, we had some pushback from members of the community, and we ended up adding that upper flag, but we decided that we were not going to advertise it too much.

That's the historical context of that weird flag :)

@kit1980
Copy link
Contributor
kit1980 commented Jul 1, 2023

but we decided that we were not going to advertise it too much.

I see, I'll use .mH then.

@kit1980
Copy link
Contributor
kit1980 commented Jul 1, 2023

@lezcano mH, not mT, right?

@lezcano
Copy link
Collaborator
lezcano commented Jul 1, 2023

mH so that it works also for complex inputs.

@lezcano
Copy link
Collaborator
lezcano commented Jul 1, 2023

ah, I see, yeah, I meant mH in the previous message :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
82F5
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed module: amp (automated mixed precision) autocast module: deprecation module: inductor module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul no-stale open source release notes: linalg_frontend release notes category topic: deprecation topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0