10000 Upgrade miniconda to 24.7.1-0 by huydhn · Pull Request #5659 · pytorch/test-infra · GitHub
[go: up one dir, main page]

Skip to content

Upgrade miniconda to 24.7.1-0 #5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Upgrade miniconda to 24.7.1-0 #5659

merged 2 commits into from
Sep 12, 2024

Conversation

huydhn
Copy link
Contributor
@huydhn huydhn commented Sep 12, 2024

https://conda.org/blog/2024-07-23-july-releases to support the default conda-libmamba-solver. There are failures from Nova MacOS job with the newer conda otherwise https://github.com/pytorch/executorch/actions/runs/10838270548/job/30076115714#step:9:77

Testing

pytorch/executorch#5322

Copy link
vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:48pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@huydhn huydhn requested a review from a team September 12, 2024 22:05
@@ -40,7 +41,7 @@ runs:
uses: actions/cache@v3
with:
path: ${{ runner.temp }}/miniconda
key: miniconda-${{ runner.os }}-${{ runner.arch }}-${{ inputs.python-version }}-${{ steps.get-date.outputs.today }}
key: miniconda-${{ inputs.miniconda-version }}-${{ runner.os }}-${{ runner.arch }}-${{ inputs.python-version }}-${{ steps.get-date.outputs.today }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to invalidate the current cache. In hindsight, the conda version should be part of the key anyway.

Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should plainly stop using coda during CI

@huydhn huydhn merged commit 9983937 into main Sep 12, 2024
29 checks passed
malfet pushed a commit that referenced this pull request Oct 22, 2024
https://conda.org/blog/2024-07-23-july-releases to support the default
conda-libmamba-solver. There are failures from Nova MacOS job with the
newer conda otherwise
https://github.com/pytorch/executorch/actions/runs/10838270548/job/30076115714#step:9:77

### Testing

pytorch/executorch#5322
(cherry picked from commit 9983937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0