Add RuntimeError when calling cholesky

pytorch · IvanYashchuk · Jan 7, 2022 · Mar 11, 2022 · Mar 11, 2022 · Feb 28, 2023
commit 967a8a11321c799fc20b94441192fc974a1dfa13
@@ -141,6 +141,13 @@ def run_test_case(a, b):
         run_test_case(zero_strided, b)
         run_test_case(a, zero_strided)
 
+    def test_cholesky_removed_error(self, device):
+        a = make_tensor(5, 5, device=device, dtype=torch.float32)
+        with self.assertRaisesRegex(RuntimeError, "This function was deprecated since version 1.9 and is now removed"):
+            torch.cholesky(a)
+        with self.assertRaisesRegex(RuntimeError, "This function was deprecated since version 1.9 and is now removed"):
+            a.cholesky()
+
     def test_matrix_rank_removed_error(self, device):
         a = make_tensor(5, 5, device=device, dtype=torch.float32)
         with self.assertRaisesRegex(RuntimeError, "This function was deprecated since version 1.9 and is now removed"):

diff --git a/torch/__init__.py b/torch/__init__.py
@@ -1319,6 +1319,7 @@ def compiled_with_cxx11_abi():
 
 # Import removed ops with error message about removal
 from ._linalg_utils import (  # type: ignore[misc]
+    cholesky,
     matrix_rank,
     eig,
     solve,

diff --git a/torch/_linalg_utils.py b/torch/_linalg_utils.py
@@ -93,6 +93,11 @@ def symeig(A: Tensor, largest: Optional[bool] = False) -> Tuple[Tensor, Tensor]:
 
 # These functions were deprecated and removed
 # This nice error message can be removed in version 1.13+
+def cholesky(input: Tensor, upper: bool = False, *, out=None) -> Tensor:
+    raise RuntimeError(
+        "This function was deprecated since version 1.9 and is now removed. Please use the `torch.linalg.cholesky` function instead.",
+    )
+
 def matrix_rank(input, tol=None, symmetric=False, *, out=None) -> Tensor:
     raise RuntimeError(
         "This function was deprecated since version 1.9 and is now removed.",

diff --git a/torch/_tensor.py b/torch/_tensor.py
@@ -646,6 +646,11 @@ def norm(
             )
         return torch.norm(self, p, dim, keepdim, dtype=dtype)
 
+    def cholesky(self, upper=False):
+        from ._linalg_utils import cholesky
+
+        return cholesky(self, upper=upper)
+
     def solve(self, other):
         from ._linalg_utils import solve