Update from_dlpack tests and documentation #70543

kurtamohler · 2021-12-31T18:01:14Z

pytorch-probot · 2021-12-31T18:01:17Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/kurtamohler/pytorch/blob/da734ede4eb1624f622cfb7b596c490087be35bb/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2021-12-31T18:01:19Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70543
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 0af0353 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

rgommers · 2022-01-01T15:21:57Z

Thanks @kurtamohler! gh-70437 also updates the docs, so after whichever one of these PRs lands first, the other one needs an update.

rgommers · 2022-01-01T15:24:34Z

Was from_dlpack already moved to the torch namespace in a previous PR? I had missed that.

kurtamohler · 2022-01-02T00:22:12Z

Was from_dlpack already moved to the torch namespace in a previous PR? I had missed that.

It wasn't moved, it's still under torch.utils.dlpack. But this PR made it available under torch as well: https://github.com/pytorch/pytorch/pull/57110/files#diff-c8835eba8562819a44e70a30545213c96e68c588a2cfa673fa495b187b1ea8dfR762

rgommers

This looks good, thanks @kurtamohler. Adding tests for non-contiguous input is a good idea. Just two very minor comments from me.

docs/source/torch.rst

rgommers · 2022-01-03T16:16:29Z

test/test_torch.py

    @skipMeta
    @onlyCUDA
    @dtypes(*get_all_dtypes(include_bool=False))
    def test_dlpack_conversion_with_diff_streams(self, device, dtype):
-        from torch._C import _from_dlpack


This change is a good cleanup. No change in behavior due to this, because the test bypasses stream handling in from_dlpack by passing in a capsule rather than a tensor.

torch/utils/dlpack.py

rgommers · 2022-01-03T16:24:53Z

One related thing is what we should do with to_dlpack. It was added to the main namespace as well, is also undocumented there, but unlike from_dlpack it's not that useful (because recommended usage is torch.from_dlpack(a_tensor), no to_dlpack involved). Options include:

document it anyway
deprecate it again in the main namespace (just leave it in torch.utils.dlpack)
leave things as they are

@mruberry any preference?

Leave `to_dlpack` in the `torch.utils.dlpack` namespace here. It is present in the main namespace as well, but undocumented there and it's not clear if we want to keep it there - see pytorch#70543 (comment)

rgommers · 2022-02-10T20:49:03Z

@kurtamohler this has accumulated a merge conflict, could you resolve it?

The to_dlpack question above can be dealt with separately, it'd be good to get this merged.

mruberry

Thanks @kurtamohler!

facebook-github-bot · 2022-02-11T15:48:59Z

@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Part of #58742 Pull Request resolved: #70543 Reviewed By: soulitzer Differential Revision: D34172475 Pulled By: mruberry fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b

github-actions · 2022-02-14T03:35:53Z

Hey @kurtamohler.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Part of pytorch/pytorch#58742 Pull Request resolved: pytorch/pytorch#70543 Reviewed By: soulitzer Differential Revision: D34172475 Pulled By: mruberry fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b (cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)

rgommers · 2022-02-16T11:54:52Z

Thanks for merging @mruberry. Just to confirm: are you happy to see the doc change backported to the 1.11 branch?

Summary: Part of pytorch/pytorch#58742 Pull Request resolved: pytorch/pytorch#70543 Reviewed By: soulitzer Differential Revision: D34172475 Pulled By: mruberry fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b (cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)

mruberry · 2022-02-16T16:57:56Z

Thanks for merging @mruberry. Just to confirm: are you happy to see the doc change backported to the 1.11 branch?

Yep, sounds like a fine cherrypick. cc @malfet

Summary: Part of pytorch/pytorch#58742 Pull Request resolved: pytorch/pytorch#70543 Reviewed By: soulitzer Differential Revision: D34172475 Pulled By: mruberry fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b (cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)

kurtamohler requested a review from lezcano December 31, 2021 18:01

pytorch-probot bot added the ciflow/default label Dec 31, 2021

facebook-github-bot added the cla signed label Dec 31, 2021

pytorchbot added the open source label Dec 31, 2021

kurtamohler force-pushed the from_dlpack-public branch from dc6df1c to 489f47a Compare December 31, 2021 18:09

kurtamohler changed the title ~~Make from_dlpack public~~ Use public from_dlpack method in test Dec 31, 2021

kurtamohler force-pushed the from_dlpack-public branch from 489f47a to 6876998 Compare December 31, 2021 23:19

kurtamohler changed the title ~~Use public from_dlpack method in test~~ Update from_dlpack tests and documentation Dec 31, 2021

lezcano requested a review from rgommers January 1, 2022 14:04

rgommers approved these changes Jan 3, 2022

View reviewed changes

kurtamohler force-pushed the from_dlpack-public branch from 6876998 to da734ed Compare January 3, 2022 19:02

kurtamohler force-pushed the from_dlpack-public branch from da734ed to f236b60 Compare February 10, 2022 21:25

Update from_dlpack tests and documentation

0af0353

kurtamohler force-pushed the from_dlpack-public branch from f236b60 to 0af0353 Compare February 10, 2022 23:48

mruberry self-requested a review February 11, 2022 15:48

mruberry approved these changes Feb 11, 2022

View reviewed changes

pytorchmergebot closed this in 47c6993 Feb 14, 2022

kurtamohler added the release notes: python_frontend python frontend release notes category label Feb 14, 2022

kurtamohler added the topic: docs topic category label Feb 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update from_dlpack tests and documentation #70543

Update from_dlpack tests and documentation #70543

Uh oh!

Uh oh!

⚛️ CI Flow

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update from_dlpack tests and documentation #70543

Update from_dlpack tests and documentation #70543

Uh oh!

Conversation

Uh oh!

Uh oh!

⚛️ CI Flow

Uh oh!

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!